From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 2/3] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation Date: Tue, 3 Dec 2013 10:03:34 +0000 Message-ID: <20131203100334.GI11828@lee--X1> References: <1386007222-10081-1-git-send-email-lee.jones@linaro.org> <1386007222-10081-2-git-send-email-lee.jones@linaro.org> <529CCDAF.7050205@metafoo.de> <20131203083600.GB11828@lee--X1> <529D9CD1.3020208@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ie0-f169.google.com (mail-ie0-f169.google.com [209.85.223.169]) by alsa0.perex.cz (Postfix) with ESMTP id CF1D926514A for ; Tue, 3 Dec 2013 11:03:41 +0100 (CET) Received: by mail-ie0-f169.google.com with SMTP id e14so23844198iej.0 for ; Tue, 03 Dec 2013 02:03:41 -0800 (PST) Content-Disposition: inline In-Reply-To: <529D9CD1.3020208@metafoo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Lars-Peter Clausen Cc: alsa-devel@alsa-project.org, linus.walleij@linaro.org, broonie@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gVHVlLCAwMyBEZWMgMjAxMywgTGFycy1QZXRlciBDbGF1c2VuIHdyb3RlOgoKPiBPbiAxMi8w My8yMDEzIDA5OjM2IEFNLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPk9uIE1vbiwgMDIgRGVjIDIwMTMs IExhcnMtUGV0ZXIgQ2xhdXNlbiB3cm90ZToKPiA+Cj4gPj5PbiAxMi8wMi8yMDEzIDA3OjAwIFBN LCBMZWUgSm9uZXMgd3JvdGU6Cj4gPj4+SWYgYm9vdGluZyB3aXRoIGZ1bGwgRFQgc3VwcG9ydCAo aS5lLiBETUEgdG9vLCB0aGUgbGFzdCBwaWVjZSBvZiB0aGUKPiA+Pj5wdXp6bGUpLCB0aGVuIHdl IGRvbid0IG5lZWQgdG8gdXNlIHRoZSBjb21wYXRpYmxlIHJlcXVlc3QgY2hhbm5lbCBjYWxsCj4g Pj4+YmFjay4gV2UgYWxzbyByZXF1aXJlIHNsaWdodGx5IGRpZmZlcmVudCBmbGFncyB0byBpbmZv cm0gdGhlIGNvcmUgdGhhdAo+ID4+PndlIGFyZSBib290aW5nIHdpdGggRFQuCj4gPj4KPiA+Pkkg ZG9uJ3QgdGhpbmsgeW91IG5lZWQgZGlmZmVyZW50aWF0ZSBiZXR3ZWVuIERUIGFuZCBub24tRFQg aGVyZS4KPiA+PklmIHRoZSBTTkRfRE1BRU5HSU5FX1BDTV9GTEFHX0NPTVBBVCBpcyBzZXQgYW5k IHRoZQo+ID4+U05EX0RNQUVOR0lORV9QQ01fRkxBR19OT19EVCBpcyBub3Qgc2V0IGl0IHdpbGwg Zmlyc3QgdHJ5IHRvIHJlcXVlc3QgdGhlCj4gPj5jaGFubmVscyBmcm9tIHRoZSBEVCBpZiB0aGF0 IGZhaWxzIGl0IHdpbGwgZmFsbGJhY2sgdG8gdGhlIGNvbXBhdCBwYXRoLiBTbwo+ID4+YWxsIHRo aXMgcGF0Y2ggbmVlZHMgdG8gZG8gaXMgcmVtb3ZlIHRoZSBTTkRfRE1BRU5HSU5FX1BDTV9GTEFH X05PX0RULCB0aGF0Cj4gPj5zaG91bGQgYmUgaXQuCj4gPgo+ID5JIGhhdmUgbm8gd2F5IG9mIHRl c3RpbmcgdGhhdCwgYXMgd2UgYXJlIGN1cnJlbnRseSA4MCUgdGhyb3VnaAo+ID5zaHV0dGluZyBk b3duIHBsYXRmb3JtIGRhdGEgYWx0b2dldGhlci4gSW4gZmFjdCwgSSB0aGluayB0aGVyZSBpcyBv bmx5Cj4gPkFTb0MgdG8gYmUgY29udmVydGVkLiBNb3N0IG9mIHRoaXMgc3R1ZmYgaXMgZ29pbmcg dG8gYmUgcmlwcGVkIG91dAo+ID53aXRoaW4gdGhlIG5leHQgY291cGxlIG9mIHdlZWtzIGluIGFu eSBjYXNlLiBJdCB3aWxsIGhhcHBlbiBhcyBzb29uIGFzCj4gPkkgY2FuIGZpbmQgYW4gaG91ciBv ciB0d28gdG8gd29yayBvbiBpdC4KPiA+Cj4gPkZvciB0aGF0IHJlYXNvbiBJIGRpZG4ndCB3YW50 IHRvIGRpc3R1cmIgdGhlIGN1cnJlbnQgc2VtYW50aWNzLiBJJ3ZlCj4gPmFscmVhZHkgZm91bmQg dGhhdCBhIGJ1bmNoIG9mIGhlIGdlbmVyaWMgKG9oLCB5b3UgY2FuIGp1c3QgdXNlIHRoZQo+ID5j ZW50cmFsKSBmdW5jdGlvbnMgKGZvciB0aGF0KSBkb24ndCBhY3R1YWxseSB3b3JrIGZvciB1cyBm b3Igb25lCj4gPnJlYXNvbiBvciBhbm90aGVyLgo+IAo+IEFsbCBTTkRfRE1BRU5HSU5FX1BDTV9G TEFHX05PX0RUIGRvZXMgaXMgdG8gc2tpcCB0cnlpbmcgdG8gcmVxdWVzdAo+IHRoZSBjaGFubmVs IGZyb20gdGhlIGR0LiBJZiBvZl9ub2RlIGlzIE5VTEwgdGhpcyBzdGVwIHdpbGwgYmUKPiBza2lw cGVkIGFueXdheS4gU28gb25seSBzZXR0aW5nIFNORF9ETUFFTkdJTkVfUENNX0ZMQUdfTk9fRFQg aWYgd2UKPiBhbHJlYWR5IGtub3cgdGhhdCB0aGUgbm9kZSBpcyBOVUxMIGlzIHJlZHVuZGFudC4K CkknbGwganVzdCBoYXZlIHRvIHRydXN0IHlvdSBvbiB0aGlzIGFuZCByZXN1Ym1pdCB3aXRoIHRo ZSBvdGhlciBwYXRjaC4KCi0tIApMZWUgSm9uZXMKTGluYXJvIFNUTWljcm9lbGVjdHJvbmljcyBM YW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3Ig QVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxp bmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxzYS1w cm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 3 Dec 2013 10:03:34 +0000 Subject: [alsa-devel] [PATCH 2/3] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation In-Reply-To: <529D9CD1.3020208@metafoo.de> References: <1386007222-10081-1-git-send-email-lee.jones@linaro.org> <1386007222-10081-2-git-send-email-lee.jones@linaro.org> <529CCDAF.7050205@metafoo.de> <20131203083600.GB11828@lee--X1> <529D9CD1.3020208@metafoo.de> Message-ID: <20131203100334.GI11828@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 03 Dec 2013, Lars-Peter Clausen wrote: > On 12/03/2013 09:36 AM, Lee Jones wrote: > >On Mon, 02 Dec 2013, Lars-Peter Clausen wrote: > > > >>On 12/02/2013 07:00 PM, Lee Jones wrote: > >>>If booting with full DT support (i.e. DMA too, the last piece of the > >>>puzzle), then we don't need to use the compatible request channel call > >>>back. We also require slightly different flags to inform the core that > >>>we are booting with DT. > >> > >>I don't think you need differentiate between DT and non-DT here. > >>If the SND_DMAENGINE_PCM_FLAG_COMPAT is set and the > >>SND_DMAENGINE_PCM_FLAG_NO_DT is not set it will first try to request the > >>channels from the DT if that fails it will fallback to the compat path. So > >>all this patch needs to do is remove the SND_DMAENGINE_PCM_FLAG_NO_DT, that > >>should be it. > > > >I have no way of testing that, as we are currently 80% through > >shutting down platform data altogether. In fact, I think there is only > >ASoC to be converted. Most of this stuff is going to be ripped out > >within the next couple of weeks in any case. It will happen as soon as > >I can find an hour or two to work on it. > > > >For that reason I didn't want to disturb the current semantics. I've > >already found that a bunch of he generic (oh, you can just use the > >central) functions (for that) don't actually work for us for one > >reason or another. > > All SND_DMAENGINE_PCM_FLAG_NO_DT does is to skip trying to request > the channel from the dt. If of_node is NULL this step will be > skipped anyway. So only setting SND_DMAENGINE_PCM_FLAG_NO_DT if we > already know that the node is NULL is redundant. I'll just have to trust you on this and resubmit with the other patch. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752727Ab3LCKDr (ORCPT ); Tue, 3 Dec 2013 05:03:47 -0500 Received: from mail-ie0-f178.google.com ([209.85.223.178]:60382 "EHLO mail-ie0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003Ab3LCKDm (ORCPT ); Tue, 3 Dec 2013 05:03:42 -0500 Date: Tue, 3 Dec 2013 10:03:34 +0000 From: Lee Jones To: Lars-Peter Clausen Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, broonie@kernel.org, alsa-devel@alsa-project.org Subject: Re: [alsa-devel] [PATCH 2/3] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation Message-ID: <20131203100334.GI11828@lee--X1> References: <1386007222-10081-1-git-send-email-lee.jones@linaro.org> <1386007222-10081-2-git-send-email-lee.jones@linaro.org> <529CCDAF.7050205@metafoo.de> <20131203083600.GB11828@lee--X1> <529D9CD1.3020208@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <529D9CD1.3020208@metafoo.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 03 Dec 2013, Lars-Peter Clausen wrote: > On 12/03/2013 09:36 AM, Lee Jones wrote: > >On Mon, 02 Dec 2013, Lars-Peter Clausen wrote: > > > >>On 12/02/2013 07:00 PM, Lee Jones wrote: > >>>If booting with full DT support (i.e. DMA too, the last piece of the > >>>puzzle), then we don't need to use the compatible request channel call > >>>back. We also require slightly different flags to inform the core that > >>>we are booting with DT. > >> > >>I don't think you need differentiate between DT and non-DT here. > >>If the SND_DMAENGINE_PCM_FLAG_COMPAT is set and the > >>SND_DMAENGINE_PCM_FLAG_NO_DT is not set it will first try to request the > >>channels from the DT if that fails it will fallback to the compat path. So > >>all this patch needs to do is remove the SND_DMAENGINE_PCM_FLAG_NO_DT, that > >>should be it. > > > >I have no way of testing that, as we are currently 80% through > >shutting down platform data altogether. In fact, I think there is only > >ASoC to be converted. Most of this stuff is going to be ripped out > >within the next couple of weeks in any case. It will happen as soon as > >I can find an hour or two to work on it. > > > >For that reason I didn't want to disturb the current semantics. I've > >already found that a bunch of he generic (oh, you can just use the > >central) functions (for that) don't actually work for us for one > >reason or another. > > All SND_DMAENGINE_PCM_FLAG_NO_DT does is to skip trying to request > the channel from the dt. If of_node is NULL this step will be > skipped anyway. So only setting SND_DMAENGINE_PCM_FLAG_NO_DT if we > already know that the node is NULL is redundant. I'll just have to trust you on this and resubmit with the other patch. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog