From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753513Ab3LCLBt (ORCPT ); Tue, 3 Dec 2013 06:01:49 -0500 Received: from mail-ie0-f181.google.com ([209.85.223.181]:57388 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753461Ab3LCLBn (ORCPT ); Tue, 3 Dec 2013 06:01:43 -0500 Date: Tue, 3 Dec 2013 11:01:38 +0000 From: Lee Jones To: micky Cc: sameo@linux.intel.com, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, wei_wang@realsil.com.cn, rogerable@realtek.com Subject: Re: [PATCH v2 3/3] mfd: rtsx: prevent 'used uninitialised' warnings Message-ID: <20131203110138.GN11828@lee--X1> References: <932dcc03570ceb86316272d4eba7f4207d001def.1386051860.git.micky_ching@realsil.com.cn> <20131203104003.GJ11828@lee--X1> <529DB86D.3010002@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <529DB86D.3010002@realsil.com.cn> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >This should contain the author's name. > > > >You should use: > > `git rebase -i` /* Use edit option */ > >then > > `git commit --amend --author="First Last " > > > >To apply it. > > > Sorry Lee, I will modify it. Is the order important? or only your > name is need here? > >>drivers/mfd/rtl8411.c: In function 'rtl8411_fetch_vendor_settings': > >>drivers/mfd/rtl8411.c:58:7: warning: 'reg1' is used uninitialized in this function [-Wuninitialized] > >>drivers/mfd/rtl8411.c: In function 'rtl8411b_fetch_vendor_settings': > >>drivers/mfd/rtl8411.c:79:7: warning: 'reg' is used uninitialized in this function [-Wuninitialized] > >>drivers/mfd/rtl8411.c: In function 'rtl8411_fetch_vendor_settings': > >>drivers/mfd/rtl8411.c:69:26: warning: 'reg3' may be used uninitialized in this function [-Wuninitialized] > >> > >>Signed-off-by: Lee Jones > >>Tested-by: Micky Ching > >I know this is a bit of a strange situation, but whenever you sent > >patches to the MLs, you need to sign it off yourself too. Actually, you don't need to worry now. I already applied the patch with the correct author applied with your Ack. > Did you mean I need write like this ? > > Signed-off-by: Lee Jones > Tested-by: Micky Ching > Signed-off-by: Micky Ching As I say, this situation is a bit different, but in the normal case, yes. Then the Maintainer will probably remove some and chop them around a little to his/her liking. FYI: The top SoB is usually the author, the subsequent ones are usually gatekeepers of upstream repos. Anyone can take a patch and submit it though, so in the case where the submitter isn't the author, the second SoB is usually the patch submitter. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog