From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ie0-f174.google.com ([209.85.223.174]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vnp8u-0002Fo-Fu for linux-mtd@lists.infradead.org; Tue, 03 Dec 2013 12:31:57 +0000 Received: by mail-ie0-f174.google.com with SMTP id at1so23189532iec.5 for ; Tue, 03 Dec 2013 04:31:35 -0800 (PST) Date: Tue, 3 Dec 2013 12:31:28 +0000 From: Lee Jones To: Linus Walleij Subject: Re: [PATCH v3 14/36] mtd: st_spi_fsm: Add device-tree binding documentation Message-ID: <20131203123128.GE12031@lee--X1> References: <1385727565-25794-1-git-send-email-lee.jones@linaro.org> <1385727565-25794-15-git-send-email-lee.jones@linaro.org> <20131202110304.GB31626@lee--X1> <20131203113156.GB12031@lee--X1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Cc: "devicetree@vger.kernel.org" , angus.clark@st.com, "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , David Woodhouse , "linux-arm-kernel@lists.infradead.org" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 03 Dec 2013, Linus Walleij wrote: > On Tue, Dec 3, 2013 at 12:31 PM, Lee Jones wrote: > > On Tue, 03 Dec 2013, Linus Walleij wrote: > > >> So it can be in as > >> a > >> > >> #define MY_SYSCON_V1_BOOT_DEV_REG 0x958 > >> #define MY_SYSCON_V1_BOOT_DEV_SPI 0x1a > >> > >> The kernel should know which SoC is in use and > >> act apropriately right? > > > > And this have lots of machine_is() calls everywhere? > > No need for Mr. Everywhere to know about the SoC. > > There are other ways to achieve this. arch/arm/mach-foo > always knows which ASIC it is running on, and it can do > various things: > > - Add device tree fragments/overlays (OK high-tech, but > we're getting to this, inevitably) > > - Selectively add AUXDATA, which is absolutely OK if > we can do autoprobing of hardware IMO. I prefer our solution TBH. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 3 Dec 2013 12:31:28 +0000 Subject: [PATCH v3 14/36] mtd: st_spi_fsm: Add device-tree binding documentation In-Reply-To: References: <1385727565-25794-1-git-send-email-lee.jones@linaro.org> <1385727565-25794-15-git-send-email-lee.jones@linaro.org> <20131202110304.GB31626@lee--X1> <20131203113156.GB12031@lee--X1> Message-ID: <20131203123128.GE12031@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 03 Dec 2013, Linus Walleij wrote: > On Tue, Dec 3, 2013 at 12:31 PM, Lee Jones wrote: > > On Tue, 03 Dec 2013, Linus Walleij wrote: > > >> So it can be in as > >> a > >> > >> #define MY_SYSCON_V1_BOOT_DEV_REG 0x958 > >> #define MY_SYSCON_V1_BOOT_DEV_SPI 0x1a > >> > >> The kernel should know which SoC is in use and > >> act apropriately right? > > > > And this have lots of machine_is() calls everywhere? > > No need for Mr. Everywhere to know about the SoC. > > There are other ways to achieve this. arch/arm/mach-foo > always knows which ASIC it is running on, and it can do > various things: > > - Add device tree fragments/overlays (OK high-tech, but > we're getting to this, inevitably) > > - Selectively add AUXDATA, which is absolutely OK if > we can do autoprobing of hardware IMO. I prefer our solution TBH. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 14/36] mtd: st_spi_fsm: Add device-tree binding documentation Date: Tue, 3 Dec 2013 12:31:28 +0000 Message-ID: <20131203123128.GE12031@lee--X1> References: <1385727565-25794-1-git-send-email-lee.jones@linaro.org> <1385727565-25794-15-git-send-email-lee.jones@linaro.org> <20131202110304.GB31626@lee--X1> <20131203113156.GB12031@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , David Woodhouse , "linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , angus.clark-qxv4g6HH51o@public.gmane.org, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Tue, 03 Dec 2013, Linus Walleij wrote: > On Tue, Dec 3, 2013 at 12:31 PM, Lee Jones wro= te: > > On Tue, 03 Dec 2013, Linus Walleij wrote: >=20 > >> So it can be in as > >> a > >> > >> #define MY_SYSCON_V1_BOOT_DEV_REG 0x958 > >> #define MY_SYSCON_V1_BOOT_DEV_SPI 0x1a > >> > >> The kernel should know which SoC is in use and > >> act apropriately right? > > > > And this have lots of machine_is() calls everywhere? >=20 > No need for Mr. Everywhere to know about the SoC. >=20 > There are other ways to achieve this. arch/arm/mach-foo > always knows which ASIC it is running on, and it can do > various things: >=20 > - Add device tree fragments/overlays (OK high-tech, but > we're getting to this, inevitably) >=20 > - Selectively add AUXDATA, which is absolutely OK if > we can do autoprobing of hardware IMO. I prefer our solution TBH. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753262Ab3LCMbk (ORCPT ); Tue, 3 Dec 2013 07:31:40 -0500 Received: from mail-ie0-f173.google.com ([209.85.223.173]:43099 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496Ab3LCMbg (ORCPT ); Tue, 3 Dec 2013 07:31:36 -0500 Date: Tue, 3 Dec 2013 12:31:28 +0000 From: Lee Jones To: Linus Walleij Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , David Woodhouse , "linux-mtd@lists.infradead.org" , angus.clark@st.com, "devicetree@vger.kernel.org" Subject: Re: [PATCH v3 14/36] mtd: st_spi_fsm: Add device-tree binding documentation Message-ID: <20131203123128.GE12031@lee--X1> References: <1385727565-25794-1-git-send-email-lee.jones@linaro.org> <1385727565-25794-15-git-send-email-lee.jones@linaro.org> <20131202110304.GB31626@lee--X1> <20131203113156.GB12031@lee--X1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 03 Dec 2013, Linus Walleij wrote: > On Tue, Dec 3, 2013 at 12:31 PM, Lee Jones wrote: > > On Tue, 03 Dec 2013, Linus Walleij wrote: > > >> So it can be in as > >> a > >> > >> #define MY_SYSCON_V1_BOOT_DEV_REG 0x958 > >> #define MY_SYSCON_V1_BOOT_DEV_SPI 0x1a > >> > >> The kernel should know which SoC is in use and > >> act apropriately right? > > > > And this have lots of machine_is() calls everywhere? > > No need for Mr. Everywhere to know about the SoC. > > There are other ways to achieve this. arch/arm/mach-foo > always knows which ASIC it is running on, and it can do > various things: > > - Add device tree fragments/overlays (OK high-tech, but > we're getting to this, inevitably) > > - Selectively add AUXDATA, which is absolutely OK if > we can do autoprobing of hardware IMO. I prefer our solution TBH. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog