All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Ruder <andrew.ruder@elecsyscorp.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] smbnetfs: new package 0.5.3a
Date: Tue, 3 Dec 2013 07:30:43 -0600	[thread overview]
Message-ID: <20131203133043.GA6637@gmail.com> (raw)
In-Reply-To: <20131203094701.08480f23@skate>

Summary: I apologize for the shoddiness of this and my other patch and
I will take the info you've given me here and make much better v2's :).

On Tue, Dec 03, 2013 at 09:47:01AM +0100, Thomas Petazzoni wrote:
> We now normally wants patches to carry a sequence number, even if there
> is only one patch. So something like:
> 
> 	smbnetfs-01-compile-with-uclibc.patch

Ok, can do for v2.

> Indentation of the help text is wrong. It should be one tab + two
> spaces.

I'll fix that for v2.

> I'm not sure here if we want to depend on Samba, or select Samba.
> Usually, we prefer "select" so that things are transparent for the
> user. However, when the thing being selected is "big", and fairly
> obvious for the user (like the Python interpreter being needed to build
> a Python module), we use depends on. I'm not sure which choice to make
> here.

Yes, I had made the decision that samba was "intrusive" enough to
require explicit selection.  I figured since it required something
outside of the Libraries section, I would make the user explicitely add
it.

> However, what is sure is that you forgot to inherit the toolchain
> dependencies of libfuse: they should be added.

Ah, I am a little unfamiliar with the intricacies of Kconfig and didn't
realize I needed to explicitely do that.  Will take care of it in v2.

> All patches should have a description + Signed-off-by. Also, it would
> be good if you could submit that patch upstream, so that it gets
> integrated in a future release.

OK, fair enough - can do on both counts.

> No SMBNETFS_DEPENDENCIES to ensure libfuse, libiconv and samba are
> built before smbnetfs?
> 
> Also, we now request all new packages to have SMBNETFS_LICENSE and
> SMBNETFS_LICENSE_FILES.

v2 and v2.

  reply	other threads:[~2013-12-03 13:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02 23:09 [Buildroot] [PATCH] smbnetfs: new package 0.5.3a Andrew Ruder
2013-12-03  8:47 ` Thomas Petazzoni
2013-12-03 13:30   ` Andrew Ruder [this message]
2013-12-03 13:41     ` Thomas Petazzoni
2013-12-03 13:46       ` Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131203133043.GA6637@gmail.com \
    --to=andrew.ruder@elecsyscorp.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.