From: Borislav Petkov <bp@alien8.de>
To: "Chen, Gong" <gong.chen@linux.intel.com>
Cc: Levente Kurusa <levex@linux.com>, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Tony Luck <tony.luck@intel.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, EDAC <linux-edac@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: mcheck: call put_device on device_register failure
Date: Tue, 3 Dec 2013 18:01:50 +0100 [thread overview]
Message-ID: <20131203170150.GA5369@pd.tnic> (raw)
In-Reply-To: <20131203022330.GA25136@gchen.bj.intel.com>
Can you please fix your
Mail-Followup-To:
header? It is impossible to reply to your emails without fiddling with
the To: and Cc: by hand which gets very annoying over time.
On Mon, Dec 02, 2013 at 09:23:30PM -0500, Chen, Gong wrote:
> I have some concerns about it. if device_register is failed, it will
> backtraces all kinds of conditions automatically, including put_device
> definately. So do we really need an extra put_device when it returns
> failure?
Do you mean the "done:" label in device_add() which does put_device()
and which gets called by device_register()?
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-12-03 17:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 20:28 [PATCH] x86: mcheck: call put_device on device_register failure Levente Kurusa
2013-11-29 20:56 ` Borislav Petkov
2013-11-30 7:30 ` Levente Kurusa
2013-11-30 11:12 ` Borislav Petkov
2013-11-30 11:25 ` Levente Kurusa
2013-11-30 11:32 ` Borislav Petkov
2013-11-30 11:44 ` Levente Kurusa
2013-11-30 12:08 ` Borislav Petkov
2013-11-30 12:37 ` Levente Kurusa
2013-12-03 2:23 ` Chen, Gong
2013-12-03 17:01 ` Borislav Petkov [this message]
2013-12-04 7:38 ` Chen, Gong
2013-12-04 18:39 ` Levente Kurusa
2013-12-05 2:57 ` Chen, Gong
2013-12-05 11:18 ` Levente Kurusa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203170150.GA5369@pd.tnic \
--to=bp@alien8.de \
--cc=gong.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=levex@linux.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.