All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Gary Rookard <garyrookard@gmail.com>
Cc: lisa@xenapiadmin.com, devel@driver.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: bcm: Fixed non_standard kernel style, also eliminated debug messages.
Date: Tue, 3 Dec 2013 09:36:41 -0800	[thread overview]
Message-ID: <20131203173641.GA22882@kroah.com> (raw)
In-Reply-To: <1386063346-11787-1-git-send-email-garyrookard@gmail.com>

On Tue, Dec 03, 2013 at 04:35:46AM -0500, Gary Rookard wrote:
> Fixed non_standard kernel style, also eliminated debug messages. Started replacing CamelCase.

You are doing multiple things in one patch, never a good thing, please
break this up into logical, individual patches.

Also, it doesn't apply to my tree, use the staging-next branch of
staging.git on git.kernel.org or linux-next.

thanks,

greg k-h

      reply	other threads:[~2013-12-03 17:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03  9:35 [PATCH] Staging: bcm: Fixed non_standard kernel style, also eliminated debug messages Gary Rookard
2013-12-03 17:36 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131203173641.GA22882@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driver.osuosl.org \
    --cc=garyrookard@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lisa@xenapiadmin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.