From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
Kit Westneat <kwestneat@ddn.com>
Subject: Re: [PATCH 05/10] libext2fs: add explicit casts to ext2fs.h
Date: Tue, 3 Dec 2013 14:52:38 -0500 [thread overview]
Message-ID: <20131203195238.GA14229@thunk.org> (raw)
In-Reply-To: <20131203191608.GC9535@birch.djwong.org>
On Tue, Dec 03, 2013 at 11:16:08AM -0800, Darrick J. Wong wrote:
>
> The function prototypes up around line 1604 need to be updated:
>
> In file included from inline.c:38:0:
> ext2fs.h:1810:17: error: conflicting types for ‘ext2fs_group_of_blk’
> ext2fs.h:1604:12: note: previous declaration of ‘ext2fs_group_of_blk’ was here
> ext2fs.h:1817:17: error: conflicting types for ‘ext2fs_group_of_ino’
> ext2fs.h:1605:12: note: previous declaration of ‘ext2fs_group_of_ino’ was here
Nice catch; I didn't get these errors on my build for some reason.
I've applied your fix, thanks.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-12-03 19:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <529CF0D2.2010707@ddn.com>
2013-12-02 20:47 ` [PATCH] e2fsck: blk64_t to blk_t truncation Kit Westneat
2013-12-02 21:48 ` Darrick J. Wong
2013-12-03 0:25 ` Theodore Ts'o
2013-12-03 5:10 ` [PATCH 00/10] Fix 64-bit type conversion issues in e2fsck Theodore Ts'o
2013-12-03 5:10 ` [PATCH 01/10] e2fsck: use problem_t to suppress some -Wconversion warnings Theodore Ts'o
2013-12-03 5:10 ` [PATCH 02/10] e2fsck: use errcode_t " Theodore Ts'o
2013-12-03 5:10 ` [PATCH 03/10] e2fsck: use blk_t instead of blk64_t in check_resize_inode() Theodore Ts'o
2013-12-03 5:10 ` [PATCH 04/10] dumpe2fs: fix printing of block offsets for 64-bit file systems Theodore Ts'o
2013-12-03 5:10 ` [PATCH 05/10] libext2fs: add explicit casts to ext2fs.h Theodore Ts'o
2013-12-03 19:16 ` Darrick J. Wong
2013-12-03 19:52 ` Theodore Ts'o [this message]
2013-12-03 20:13 ` Darrick J. Wong
2013-12-03 5:10 ` [PATCH 06/10] libext2fs: add explicit casts to bitops.h Theodore Ts'o
2013-12-03 5:10 ` [PATCH 07/10] e2fsck: fix j_maxlen if the file system is exactly 1 << 32 blocks Theodore Ts'o
2013-12-03 5:10 ` [PATCH 08/10] e2fsck: add support for 64-bit extended attribute block refcounting Theodore Ts'o
2013-12-03 5:10 ` [PATCH 09/10] e2fsck: use dgrp_t for block group numbers Theodore Ts'o
2013-12-03 5:10 ` [PATCH 10/10] libext2fs: fix printf conversion spec in tst_iscan.c Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203195238.GA14229@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=kwestneat@ddn.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.