All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain: Allow ld64.so linker
Date: Tue, 3 Dec 2013 22:14:37 +1100	[thread overview]
Message-ID: <20131203221437.106b6bf5@kryten> (raw)
In-Reply-To: <20131202110923.2ac86fb5@skate>


Hi Thomas,

> Can you add to the commit log the specific toolchain/situation for
> which this is needed? The external toolchain logic is full of special
> cases, and I very often read the commit logs to find out why such or
> such special case was added.

Definitely. How does this look?

--
From: Jeremy Kerr <jk@ozlabs.org>

The glibc dynamic linkers for ppc64 and s390x are named ld64.so.*
so modify the check_glibc check to match them.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Anton Blanchard <anton@samba.org>
---

diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
index a8944ce..faa9d90 100644
--- a/toolchain/helpers.mk
+++ b/toolchain/helpers.mk
@@ -204,7 +204,7 @@ check_glibc_rpc_feature = \
 #
 check_glibc = \
 	SYSROOT_DIR="$(strip $1)"; \
-	if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' | wc -l` -eq 0 ; then \
+	if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' -o -name 'ld64.so.*' | wc -l` -eq 0 ; then \
 		echo "Incorrect selection of the C library"; \
 		exit -1; \
 	fi; \

  reply	other threads:[~2013-12-03 11:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02  6:23 [Buildroot] [PATCH] toolchain: Allow ld64.so linker Anton Blanchard
2013-12-02 10:09 ` Thomas Petazzoni
2013-12-03 11:14   ` Anton Blanchard [this message]
2013-12-03 11:21     ` Thomas Petazzoni
2013-12-03 11:28       ` Anton Blanchard
2013-12-03 12:16         ` Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2013-12-03 11:26 Anton Blanchard
2013-12-03 11:28 ` Thomas Petazzoni
2013-12-03 12:11 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131203221437.106b6bf5@kryten \
    --to=anton@samba.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.