Re: [Qemu-devel] [RFC V3 7/7] qmp: Allow to take external snapshots on bs graphs node.

["Benoît Canet" <benoit.canet@irqsave.net>]

Le Wednesday 04 Dec 2013 à 11:51:26 (+0800), Fam Zheng a écrit :
> On 2013年12月03日 21:26, Benoît Canet wrote:
> >Signed-off-by: Benoit Canet <benoit@irqsave.net>
> >---
> >  blockdev.c       | 49 +++++++++++++++++++++++++++++++++++++++++--------
> >  hmp.c            |  4 +++-
> >  qapi-schema.json | 13 ++++++++++---
> >  qmp-commands.hx  | 11 ++++++++++-
> >  4 files changed, 64 insertions(+), 13 deletions(-)
> >
> >diff --git a/blockdev.c b/blockdev.c
> >index e314d62..68d4ad1 100644
> >--- a/blockdev.c
> >+++ b/blockdev.c
> >@@ -940,14 +940,22 @@ static void blockdev_do_action(int kind, void *data, Error **errp)
> >      qmp_transaction(&list, errp);
> >  }
> >
> >-void qmp_blockdev_snapshot_sync(const char *device, const char *snapshot_file,
> >-                                bool has_format, const char *format,
> >-                                bool has_mode, enum NewImageMode mode,
> >-                                Error **errp)
> >+void qmp_blockdev_snapshot_sync(bool has_device, const char * device,
> >+                                bool has_node_name, const char * node_name,
> >+                                const char * snapshot_file,
> >+                                bool has_snapshot_node_name,
> >+                                const char * snapshot_node_name,
> >+                                bool has_format, const char * format,
> 
> Same question with some other function declarations and definitions
> in this series: you are adding an extra whitespace between * and
> pointer name, is it intended?

No I copy/pasted qmp generated prototypes.

Best regards

Benoît

> 
> Thanks,
> Fam
>