Re: [PATCH 12/14] arago-tisdk-connectivity: Restored connectivity modules compilation

[Denys Dmytriyenko <denys@ti.com>]

On Mon, Dec 02, 2013 at 04:09:07PM +0200, Yaniv Mahani wrote:
> From: Yaniv Machani <yanivma@ti.com>
> 
> - Modules compatibility issues with libnl were fixed.
> 
> Signed-off-by: Yaniv Machani <yanivma@ti.com>
> ---
>  .../packagegroup-arago-tisdk-connectivity.bb       |   16 ++++++----------
>  1 files changed, 6 insertions(+), 10 deletions(-)
> 
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
> index 0aa019d..c159b9d 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
> @@ -1,6 +1,6 @@
>  DESCRIPTION = "Task to install wlan and bluetooth packages into the target FS"
>  LICENSE = "MIT"
> -PR = "r17"
> +PR = "r18"
>  
>  inherit packagegroup
>  
> @@ -23,14 +23,11 @@ WLAN_COMMON = "\
>      pulseaudio-module-bluetooth-device \
>      eventdump \
>      ${@base_contains('WILINK_VERSION','WILINK-8','wlconf','',d)} \
> +    wpa-supplicant \
> +    crda \
> +    hostap-daemon \
> +    ti-wifi-utils \
>  "
> -
> -# TI/ECS versions of wpa-supplicant/crda/hostap/wifi-utils require older libnl,
> -# which no longer exists
> -#    wpa-supplicant
> -#    crda
> -#    hostap-daemon
> -#    ti-wifi-utils


>  # No bluetooth/bluetooth.h
>  #    oppserver

As oppserver used to be in common list, I commented it out here as 
unbuildable. Since you took care of it below for WiLink6, please remove the 
comment above.

BTW, what is the statis of Bluetooth in WiLink8? If it's not supported at all, 
should we also remove the other traces of BT, like bluez etc?


> @@ -42,8 +39,7 @@ WLAN_COMMON = "\
>  #    ti-compat-bluetooth

What about other commented out pieces:

ti-compat-wireless-wl12xx
ti-compat-bluetooth
wifi-direct-demo
battleship
wpa-gui-e

Although I see the patch from Eyal to update ti-compat-wireless - I assume 
you'd want to update this packagegroup again.


>  FIRMWARE_AND_DRIVERS = "\
> -    bt-firmware \
> -    bt-enable \
> +    "${@base_contains('WILINK_VERSION','WILINK-6',' oppserver bt-firmware bt-enable' , '',d)}"

Not critical, but there are some "ugly" whitespaces inside the parentheses 
above.


>      wl12xx-firmware \
>  "
>  
> -- 
> 1.7.9
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago