All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: Yaniv Mahani <yanivma@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [PATCH 07/14] ti-wifi-utils-wl18xx: Update recipe to ol_r8.a8.08 version.
Date: Wed, 4 Dec 2013 01:26:20 -0500	[thread overview]
Message-ID: <20131204062619.GT690@edge> (raw)
In-Reply-To: <1385638643-11878-1-git-send-email-yanivma@ti.com>

On Thu, Nov 28, 2013 at 01:37:23PM +0200, Yaniv Mahani wrote:
> From: Yaniv Machani <yanivma@ti.com>
> 
> - Updated firmware name.
> - Added required makefile parameter to support libnl3 compilation.
> 
> Signed-off-by: Yaniv Machani <yanivma@ti.com>
> ---
>  ...8.a6.01.bb => ti-wifi-utils-wl18xx_r8.a8.08.bb} |   13 ++++++++-----
>  .../ti-wifi-utils/ti-wifi-utils.inc                |    6 +++---
>  2 files changed, 11 insertions(+), 8 deletions(-)
>  copy meta-arago-extras/recipes-devtools/ti-wifi-utils/{ti-wifi-utils-wl18xx_r8.a6.01.bb => ti-wifi-utils-wl18xx_r8.a8.08.bb} (68%)
> 
> diff --git a/meta-arago-extras/recipes-devtools/ti-wifi-utils/ti-wifi-utils-wl18xx_r8.a6.01.bb b/meta-arago-extras/recipes-devtools/ti-wifi-utils/ti-wifi-utils-wl18xx_r8.a8.08.bb
> similarity index 68%
> copy from meta-arago-extras/recipes-devtools/ti-wifi-utils/ti-wifi-utils-wl18xx_r8.a6.01.bb
> copy to meta-arago-extras/recipes-devtools/ti-wifi-utils/ti-wifi-utils-wl18xx_r8.a8.08.bb
> index eab94fa..601b203 100644
> --- a/meta-arago-extras/recipes-devtools/ti-wifi-utils/ti-wifi-utils-wl18xx_r8.a6.01.bb
> +++ b/meta-arago-extras/recipes-devtools/ti-wifi-utils/ti-wifi-utils-wl18xx_r8.a8.08.bb
> @@ -3,12 +3,12 @@ LICENSE = "BSD"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=4725015cb0be7be389cf06deeae3683d"
>  
>  DEPENDS = "libnl"
> -RDEPENDS_${PN} = "ti-compat-wireless-wl12xx wl12xx-firmware"
> +RDEPENDS_${PN} = "wl18xx-firmware"

I guess this was a bug in the previous r8.a6.01 version. Ok...


> -PR ="r3+gitr${SRCPV}"
> +PR ="r0+gitr${SRCPV}"
>  
> -# Tag: ol_r8.a6.01
> -SRCREV = "214dfbdf97cc390b0020c4ea9331a1cf82240a64"
> +#Tag: ol_r8.a8.08
> +SRCREV = "9627cb09b9de32b8ffcc32d3ce3e275b7c56d8e4"
>  SRC_URI = "git://github.com/TI-OpenLink/18xx-ti-utils.git \
>  "
>  
> @@ -20,7 +20,10 @@ RCONFLICTS_${PN} +=  "ti-wifi-utils"
>  S = "${WORKDIR}/git"
>  
>  export CROSS_COMPILE = "${TARGET_PREFIX}"
> -CFLAGS += " -DCONFIG_LIBNL20"
> +
> +EXTRA_OEMAKE = 'CFLAGS="${CFLAGS} -I${STAGING_INCDIR}/libnl3/ -DCONFIG_LIBNL32 " \
> +		LDFLAGS="${LDFLAGS} -L${STAGING_LIBDIR}" \
> +		NLVER=3'
>  
>  do_install() {
>      install -d ${D}${bindir}
> diff --git a/meta-arago-extras/recipes-devtools/ti-wifi-utils/ti-wifi-utils.inc b/meta-arago-extras/recipes-devtools/ti-wifi-utils/ti-wifi-utils.inc
> index cdb3746..1f3ddba 100644
> --- a/meta-arago-extras/recipes-devtools/ti-wifi-utils/ti-wifi-utils.inc
> +++ b/meta-arago-extras/recipes-devtools/ti-wifi-utils/ti-wifi-utils.inc
> @@ -2,16 +2,16 @@ DESCRIPTION = "The calibrator and other useful utilities for TI wireless solutio
>  LICENSE = "BSD"
>  
>  DEPENDS = "libnl"
> -RDEPENDS_${PN} = "ti-compat-wireless-wl12xx wl12xx-firmware"
> +RDEPENDS_${PN} = "wl18xx-firmware"

Now, here you are updating a common .inc file that is still being used by 
WiLink6 versions r5.00.18 and r5.sp3.05. You shouldn't actually do it, as this 
.inc file is not even being used by WiLink8 recipe...


> -PR ="r1"
> +PR ="r2"
>  
>  SRC_URI = "git://github.com/TI-OpenLink/ti-utils.git;protocol=git"
>  
>  S = "${WORKDIR}/git"
>  
>  export CROSS_COMPILE = "${TARGET_PREFIX}"
> -CFLAGS += " -DCONFIG_LIBNL20"
> +CFLAGS+="-DCONFIG_LIBNL32"

First of all, there should be spaces around += operator.
Second, you are changing this file for WiLink6 recipes. Can they be built 
against libnl3?


>  do_install() {
>  	install -d ${D}${bindir}
> -- 
> 1.7.9
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


      parent reply	other threads:[~2013-12-04  6:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-28 11:37 [PATCH 07/14] ti-wifi-utils-wl18xx: Update recipe to ol_r8.a8.08 version Yaniv Mahani
2013-11-30 17:46 ` Cooper Jr., Franklin
2013-12-04  6:26 ` Denys Dmytriyenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131204062619.GT690@edge \
    --to=denys@ti.com \
    --cc=meta-arago@arago-project.org \
    --cc=yanivma@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.