From: Dan Carpenter <dan.carpenter@oracle.com>
To: Aldo Iljazi <mail@aldo.io>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] Staging: speakup: synth.c: removed a space
Date: Wed, 4 Dec 2013 10:38:25 +0300 [thread overview]
Message-ID: <20131204073824.GP28413@mwanda> (raw)
In-Reply-To: <20131204043515.GB6909@linux>
On Wed, Dec 04, 2013 at 06:35:15AM +0200, Aldo Iljazi wrote:
> Samuel Thibault wrote:
>
> > Err, I'd rather make it really visible that the for loop doesn't have
> > its first statement?
>
> Wouldn't it be better if you add a comment there? So it would follow the
> coding style?
No. Adding obvious comments is more annoying than the space.
This seems like a small bug in checkpatch.pl. Joe, the problem is this
code:
for ( ; x; x++) {
It's complaining about the space character before the semicolon.
regards,
dan carpenter
next prev parent reply other threads:[~2013-12-04 7:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 20:08 [PATCH] Staging: speakup: synth.c: removed a space Aldo Iljazi
2013-12-03 22:17 ` Samuel Thibault
2013-12-04 4:35 ` Aldo Iljazi
2013-12-04 7:38 ` Dan Carpenter [this message]
2013-12-04 7:45 ` Joe Perches
2013-12-04 8:21 ` Dan Carpenter
2013-12-04 13:47 ` [PATCH -next] checkpatch: Warn only on "space before semicolon" at end of line Joe Perches
2013-12-05 7:41 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204073824.GP28413@mwanda \
--to=dan.carpenter@oracle.com \
--cc=apw@canonical.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@aldo.io \
--cc=samuel.thibault@ens-lyon.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.