From: Ingo Molnar <mingo@kernel.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
peterz@infradead.org, ak@linux.intel.com, jolsa@redhat.com,
zheng.z.yan@intel.com
Subject: Re: [PATCH] perf/x86: fix bug in event constraint end marker macro
Date: Wed, 4 Dec 2013 10:03:36 +0100 [thread overview]
Message-ID: <20131204090336.GA31973@gmail.com> (raw)
In-Reply-To: <20131204090028.GA9724@quad>
* Stephane Eranian <eranian@google.com> wrote:
> #define EVENT_CONSTRAINT_END \
> - EVENT_CONSTRAINT(0, 0, 0)
> + { .idxmsk64 = 0, \
> + .code = 0, \
> + .cmask = 0, \
> + .weight = -1, \
> + .overlap = 0, \
> + .flags = 0, \
> +}
A nit, simply writing:
#define EVENT_CONSTRAINT_END { .weight = -1, }
... should be enough as initialization to zero is guaranteed for the
other fields.
Thanks,
Ingo
next prev parent reply other threads:[~2013-12-04 9:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 9:00 [PATCH] perf/x86: fix bug in event constraint end marker macro Stephane Eranian
2013-12-04 9:03 ` Ingo Molnar [this message]
2013-12-04 18:39 ` Stephane Eranian
2013-12-04 19:01 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2013-12-04 8:34 Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204090336.GA31973@gmail.com \
--to=mingo@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.