All of lore.kernel.org
 help / color / mirror / Atom feed
From: LW@KARO-electronics.de (Lothar Waßmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: i.MX27: Configure GPIOs as "input" by default
Date: Wed, 4 Dec 2013 09:57:03 +0100	[thread overview]
Message-ID: <20131204095703.236ccbe0@ipc1.ka-ro> (raw)
In-Reply-To: <20131203133045.GC28465@pengutronix.de>

Hi,

Markus Pargmann wrote:
> Hi,
> 
> On Tue, Dec 03, 2013 at 04:46:27PM +0800, Shawn Guo wrote:
> > On Sat, Nov 30, 2013 at 11:03:20AM +0400, Alexander Shiyan wrote:
> > > This patch changes the default direction for pins used
> > > as GPIO to "input". This prevents a short circuit on the
> > > configuration stage when GPIO-pin is connected to the
> > > other output pin.
> > 
> > Markus,
> > 
> > Does it make sense to you?
> 
> I am not sure if this really happens. However, it does make sense and I
> can't see any disadvantages in changing the default GPIO mux direction to
> input.
> 
What happens, if the bootloader already set up a pin as output and
linux later does the pinconfig stuff?
If the pin is reconfigured as input then, this may produce an unwanted
glitch on the pin. IMO the pinconfig driver should not touch the pin
direction, but leave it to the gpio driver to set that up. 


Lothar Wa?mann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________

  reply	other threads:[~2013-12-04  8:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-30  7:03 [PATCH] ARM: dts: i.MX27: Configure GPIOs as "input" by default Alexander Shiyan
2013-12-03  8:46 ` Shawn Guo
2013-12-03 13:30   ` Markus Pargmann
2013-12-04  8:57     ` Lothar Waßmann [this message]
2013-12-04  9:04       ` Alexander Shiyan
2013-12-04  9:13         ` Lothar Waßmann
2013-12-04  9:24           ` Alexander Shiyan
2013-12-04 10:07             ` Lothar Waßmann
2013-12-04 10:16               ` Alexander Shiyan
2013-12-04 11:15                 ` Lothar Waßmann
2013-12-04 11:33                   ` Alexander Shiyan
2013-12-04 11:58                     ` Lothar Waßmann
2013-12-03 13:37 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131204095703.236ccbe0@ipc1.ka-ro \
    --to=lw@karo-electronics.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.