From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ana Rey <anarey@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] xtables-standalone: call nft_fini in the error path
Date: Wed, 4 Dec 2013 12:18:54 +0100 [thread overview]
Message-ID: <20131204111854.GA12266@localhost> (raw)
In-Reply-To: <1385981005-2843-1-git-send-email-anarey@gmail.com>
On Mon, Dec 02, 2013 at 11:43:25AM +0100, Ana Rey wrote:
> This error is shown with valgrind tools:
>
> valgrind --leak-check=full xtables -A INPUT -i eth0 -p tcp --dport 80 -m state --state NEW,ESTABLISHED -j ACCEPT
>
> ==7377== 16 bytes in 1 blocks are still reachable in loss record 1 of 14
> ==7377== at 0x4C2B514: calloc (vg_replace_malloc.c:593)
> ==7377== by 0x574CC76: mnl_socket_open (socket.c:117)
> ==7377== by 0x417495: nft_init (nft.c:598)
> ==7377== by 0x4134C2: xtables_main (xtables-standalone.c:64)
> ==7377== by 0x5B87994: (below main) (libc-start.c:260)
>
> This patch calls nft_fini to release the objects that have been allocated in
> nft_init. This function was not used so far.
Applied, thanks Ana.
prev parent reply other threads:[~2013-12-04 11:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 10:43 [PATCH] xtables-standalone: call nft_fini in the error path Ana Rey
2013-12-04 11:18 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204111854.GA12266@localhost \
--to=pablo@netfilter.org \
--cc=anarey@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.