From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ana Rey <anarey@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] nft: fixed memory leaks in nft_xtables_config_load
Date: Wed, 4 Dec 2013 12:21:22 +0100 [thread overview]
Message-ID: <20131204112122.GB12266@localhost> (raw)
In-Reply-To: <1385981088-2984-1-git-send-email-anarey@gmail.com>
On Mon, Dec 02, 2013 at 11:44:48AM +0100, Ana Rey wrote:
> Those errors are shown with the valgrind tool:
>
> valgrind --leak-check=full xtables -A INPUT -i eth0 -p tcp --dport 80
>
> ==7377==
> ==7377== 16 bytes in 1 blocks are definitely lost in loss record 2 of 14
> ==7377== at 0x4C2B514: calloc (vg_replace_malloc.c:593)
> ==7377== by 0x5955B02: nft_table_list_alloc (table.c:425)
> ==7377== by 0x4186EB: nft_xtables_config_load (nft.c:2427)
> ==7377== by 0x4189E6: nft_rule_append (nft.c:991)
> ==7377== by 0x413A7D: add_entry.isra.6 (xtables.c:424)
> ==7377== by 0x41524A: do_commandx (xtables.c:1176)
> ==7377== by 0x4134DC: xtables_main (xtables-standalone.c:72)
> ==7377== by 0x5B87994: (below main) (libc-start.c:260)
> ==7377==
> ==7377== 16 bytes in 1 blocks are definitely lost in loss record 3 of 14
> ==7377== at 0x4C2B514: calloc (vg_replace_malloc.c:593)
> ==7377== by 0x5956A32: nft_chain_list_alloc (chain.c:888)
> ==7377== by 0x4186F3: nft_xtables_config_load (nft.c:2428)
> ==7377== by 0x4189E6: nft_rule_append (nft.c:991)
> ==7377== by 0x413A7D: add_entry.isra.6 (xtables.c:424)
> ==7377== by 0x41524A: do_commandx (xtables.c:1176)
> ==7377== by 0x4134DC: xtables_main (xtables-standalone.c:72)
> ==7377== by 0x5B87994: (below main) (libc-start.c:260)
>
> Fix these leaks and consolidate error handling in the exit path of
> nft_xtables_config_load
Applied, thanks Ana.
prev parent reply other threads:[~2013-12-04 11:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 10:44 [PATCH] nft: fixed memory leaks in nft_xtables_config_load Ana Rey
2013-12-04 11:21 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204112122.GB12266@localhost \
--to=pablo@netfilter.org \
--cc=anarey@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.