From: Colin Watson <cjwatson@ubuntu.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Fix grub-shell to avoid breaking "make distcheck"
Date: Wed, 4 Dec 2013 13:37:17 +0000 [thread overview]
Message-ID: <20131204133717.GA25568@riva.ucam.org> (raw)
In-Reply-To: <529C1D6A.4070600@gmail.com>
On Mon, Dec 02, 2013 at 06:40:58AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 29.11.2013 15:12, Colin Watson wrote:
> > Copying the themes directory in grub-shell isn't
> > parallel-test-friendly and breaks on the second test when the source
> > directory is read-only (as in "make distcheck"). Instead, add a
> > --themes-directory option to grub-mkrescue et al, and use it in
> > grub-shell.
>
> I agree with the patch but I'm unsure whether --themes-idrectory has to
> be a hidden option or appear in --help.
I made it a hidden option, merged, and pushed. Thanks.
--
Colin Watson [cjwatson@ubuntu.com]
prev parent reply other threads:[~2013-12-04 13:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 14:12 [PATCH] Fix grub-shell to avoid breaking "make distcheck" Colin Watson
2013-12-02 5:40 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-04 13:37 ` Colin Watson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204133717.GA25568@riva.ucam.org \
--to=cjwatson@ubuntu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.