Re: [RFC PATCH v3] mipi-dsi-bus: add MIPI DSI bus support

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1508 bytes --]

On Wed, Dec 04, 2013 at 04:35:12PM +0100, Andrzej Hajda wrote:
> MIPI DSI bus allows to model DSI hosts and DSI devices using Linux bus.
> DSI host should be registered by DSI master driver. During registration
> DSI devices will be created according to Device Tree sub-nodes,
> registration based on board info will be added later.
> DSI host exposes operations which can be used by slave drivers
> to access associated devices.
> 
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> Hi Thierry,
> 
> This is the 3rd version of MIPI DSI bus patch.
> Most of changes comes from Thierry comments.
> The main difference is complete change of 'philosophy' behind it.
> In previous version DSI host could be standalone driver without DRM
> dependency. In the current version it should be DRM device.
> This change breaks my drivers so I cannot test this version of patch on live system yet.

From a brief glance this looks pretty good. I'll start porting the Tegra
DSI driver to this and report back.

> There are few things which still bother me:
> - DSI mode flags - some of them seems to be too specific for my HW,
> - other DSI parameters, probably there should be more, like max clock, supported pixel modes,....

I think both of those can be extended or cleaned up once we have a few
working drivers. No need to try and make it perfect right away, chances
are we'll get a few things wrong anyway.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel