Re: [PATCH] mmc: omap: Fix error introduced by fix to release_mem_region() path

[Tony Lindgren <tony@atomide.com>]

* Jarkko Nikula <jarkko.nikula@bitmer.com> [131203 08:18]:
> On 12/02/2013 07:34 PM, Tony Lindgren wrote:
> > Commit 31ee9181eb92: (mmc: omap: Fix DMA configuration to not rely
> > on device id) fixed getting of the DMA resources when booted with
> > device tree. This patch however changed the handling of the
> > free_mem_region() error path by reusing the struct resource *res
> > for the DMA resources.
> > 
> > Fix the error the same way omap_hsmmc.c driver handles it, which
> > is to restore the resource before using the values to call
> > release_mem_region().
> > 
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > 
> I guess my devm_ioremap conversion would have fixed this?
> 
> http://www.spinics.net/lists/linux-mmc/msg23317.html

Probably..
 
> Does not help now but I'm thinking if queuing some of those my patches
> (3-5) on top of yours as a fix? Especially fix to NULL pointer dereference:
> 
> http://www.spinics.net/lists/linux-mmc/msg23320.html

Yeah please do, how about also adding the error log to the
description?

Regards,

Tony