From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933106Ab3LDSuf (ORCPT ); Wed, 4 Dec 2013 13:50:35 -0500 Received: from mail-yh0-f45.google.com ([209.85.213.45]:59819 "EHLO mail-yh0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932947Ab3LDSuc (ORCPT ); Wed, 4 Dec 2013 13:50:32 -0500 Date: Wed, 4 Dec 2013 15:50:24 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: linux-kernel@vger.kernel.org, Corey Ashford , Frederic Weisbecker , Ingo Molnar , Namhyung Kim , Paul Mackerras , Peter Zijlstra , Steven Rostedt , David Ahern Subject: Re: [PATCH 28/28] perf tools: Add udis86 disassembler feature check Message-ID: <20131204185024.GC14788@ghostprotocols.net> References: <1386076182-14484-1-git-send-email-jolsa@redhat.com> <1386076182-14484-29-git-send-email-jolsa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386076182-14484-29-git-send-email-jolsa@redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Dec 03, 2013 at 02:09:42PM +0100, Jiri Olsa escreveu: > Adding udis86 disassembler feature check which support > is needed for kvm:kvm_emulate_insn tracepoint. > > +$(call feature_check,udis86) > +ifeq ($(feature-udis86), 1) > + LIBTRACEEVENT_CFLAGS += -DHAVE_UDIS86 > + EXTLIBS += -ludis86 > +else > + msg := $(warning No udis86 support.); > +endif That is really an incomplete message, what package should I install? Perhaps we should add this there then: http://bit.ly/1hyrN52 Wow, that was easy, but yeah, could be made easier 8-) ;-P - Arnaldo