From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 4/5] Phy: Add DT nodes on kirkwood and Dove for the SATA PHY Date: Wed, 4 Dec 2013 20:18:26 +0100 Message-ID: <20131204191826.GA10498@lunn.ch> References: <1386177364-10164-1-git-send-email-andrew@lunn.ch> <1386177364-10164-5-git-send-email-andrew@lunn.ch> <529F8A10.7010500@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from vps0.lunn.ch ([178.209.37.122]:56914 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755824Ab3LDTSf (ORCPT ); Wed, 4 Dec 2013 14:18:35 -0500 Content-Disposition: inline In-Reply-To: <529F8A10.7010500@cogentembedded.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Sergei Shtylyov Cc: Andrew Lunn , Jason Cooper , kishon@ti.com, devicetree@vger.kernel.org, linux-ide@vger.kernel.org, Gregory Clement , Sebastian Hesselbarth On Wed, Dec 04, 2013 at 11:01:20PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/04/2013 08:16 PM, Andrew Lunn wrote: > > >Add nodes for the two SATA PHYs on kirkewood. > >Add node for the one SATA PHY on Dove. > >Add pHandles to the PHYs in the sata nodes. > > I don't think this patch should be pushed thru the libata tree. > However, you didn't Cc linux-arm-kernel... I've actually no idea how this will go upstream, since it is three different subsystems, generic phy, libata, and arm/mvebu. I will leave it up to the maintainers to decide that. I can add some more CC: for v2. > >+ sata_phy0: sata_phy@0 { > > The node should rather be named "sata-phy@0" to be in line with > "ethernet-phy" found in the ePAPR spec. [1], hyphen is generally > preferred to underscore in the device trees. O.K, will do. kirkwood.dtsi and dove.dtsi already follow this pattern of - in the @ part. Thanks Andrew