From: Arnd Bergmann <arnd@arndb.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Prarit Bhargava <prarit@redhat.com>,
linux-kernel@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/3] Introduce FW_INFO* functions and messages
Date: Wed, 4 Dec 2013 19:22:57 +0100 [thread overview]
Message-ID: <201312041922.59181.arnd@arndb.de> (raw)
In-Reply-To: <20131203132120.6a7ab2cd7cc99720712cbe6a@linux-foundation.org>
On Tuesday 03 December 2013, Andrew Morton wrote:
> I do wonder if it all should be generalised a bit - it creates a bunch
> of infrastructure which is specific to system firmware issues, but
> what's so special about firmware? Why can't I use this infrastructure
> to log netdev errors or acpi errors or PM errors or...? But I didn't
> think about it much ;)
I had similar thoughts when I read this, but I can also remember a bunch
of very overdesigned attempts to reorganize and structure the kernel
logging code. I lot of time was wasted in the past for things that
ended up being too invasive or inconsistent.
The other part I noticed about this particular patchset is that it's
not really "firmware" as such, but specifically PC wiht ACPI that
gets covered here. So rather than generalizing the code, another
option would be to narrow down the scope and make it
acpi_{warn,info,dbg} instead.
Arnd
next prev parent reply other threads:[~2013-12-04 18:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 15:19 [PATCH 0/3] Add Firmware Info, Warn, and Bug messages Prarit Bhargava
2013-12-02 15:19 ` [PATCH 1/3] Introduce FW_INFO* functions and messages Prarit Bhargava
2013-12-03 21:21 ` Andrew Morton
2013-12-04 11:51 ` Prarit Bhargava
2013-12-04 17:20 ` Joe Perches
2013-12-04 18:22 ` Arnd Bergmann [this message]
2013-12-05 11:30 ` Matt Fleming
2013-12-05 15:55 ` Joe Perches
2013-12-06 12:30 ` Matt Fleming
2013-12-16 13:01 ` Prarit Bhargava
2013-12-16 16:31 ` Joe Perches
2013-12-02 15:19 ` [PATCH 2/3] Introduce FW_WARN* " Prarit Bhargava
2013-12-02 15:19 ` [PATCH 3/3] Introduce FW_BUG* " Prarit Bhargava
2013-12-02 17:34 ` [PATCH 0/3] Add Firmware Info, Warn, and Bug messages Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312041922.59181.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.