From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] grub: force -m32 so we build grub 32 bits on 64 bits architecture
Date: Wed, 4 Dec 2013 21:39:10 +0200 [thread overview]
Message-ID: <20131204193910.GE32492@tarshish> (raw)
In-Reply-To: <1386185630-23338-1-git-send-email-thomas.petazzoni@free-electrons.com>
Hi Thomas,
On Wed, Dec 04, 2013 at 08:33:50PM +0100, Thomas Petazzoni wrote:
> As reported by Matthew Weber, Grub doesn't build on 64 bits build
> machines, because the host compiler produces 64 bits binaries by
> default, while Grub should be built 32 bits. Therefore, this commit
> passes -m32 to the Grub CFLAGS, so that 32 bits binaries are always
> produced.
>
> Reported-by: Matthew Weber <mlweber1@rockwellcollins.com>
> Cc: Matthew Weber <mlweber1@rockwellcollins.com>
For some reason Matthew does not appear on the Cc list. Added now. Shouldn't
git send-email do this automatically?
baruch
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> boot/grub/grub.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/boot/grub/grub.mk b/boot/grub/grub.mk
> index 6ba02cd..eb066af 100644
> --- a/boot/grub/grub.mk
> +++ b/boot/grub/grub.mk
> @@ -70,7 +70,7 @@ GRUB_POST_PATCH_HOOKS += GRUB_DEBIAN_PATCHES
>
> GRUB_CONF_ENV = \
> $(HOST_CONFIGURE_OPTS) \
> - CFLAGS="$(HOST_CFLAGS) $(GRUB_CFLAGS)"
> + CFLAGS="$(HOST_CFLAGS) $(GRUB_CFLAGS) -m32"
>
> GRUB_CONF_OPT = \
> --disable-auto-linux-mem-opt \
> --
> 1.8.1.2
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2013-12-04 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 19:33 [Buildroot] [PATCH] grub: force -m32 so we build grub 32 bits on 64 bits architecture Thomas Petazzoni
2013-12-04 19:39 ` Baruch Siach [this message]
2013-12-04 19:43 ` Matthew Weber
2013-12-04 21:04 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204193910.GE32492@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.