From: Florian Westphal <fw@strlen.de>
To: Shawn Landden <shawn@churchofgit.com>
Cc: netfilter-devel@vger.kernel.org, arturo.borrero.glez@gmail.com
Subject: Re: [nftables PATCH] netlink: do not SIGSEGV when socket() fails
Date: Wed, 4 Dec 2013 21:30:30 +0100 [thread overview]
Message-ID: <20131204203030.GE2767@breakpoint.cc> (raw)
In-Reply-To: <1386187281-24493-1-git-send-email-shawn@churchofgit.com>
Shawn Landden <shawn@churchofgit.com> wrote:
> + if (nf_sock == NULL) {
> + fprintf(fdopen(STDERR_FILENO, "a"),
> + "Could not open AF_NETLINK socket: %s\n",
> + strerror(errno));
Why this fdopen() [ which can fail ] construct?
next prev parent reply other threads:[~2013-12-04 20:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 19:12 [PATCH] netlink: do not SIGSEGV when socket() fails Shawn Landden
2013-12-04 19:30 ` Arturo Borrero Gonzalez
2013-12-04 20:01 ` [nftables PATCH] " Shawn Landden
2013-12-04 20:30 ` Florian Westphal [this message]
2013-12-05 3:18 ` [PATCH] " Shawn Landden
2013-12-05 9:03 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204203030.GE2767@breakpoint.cc \
--to=fw@strlen.de \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=shawn@churchofgit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.