From: Ben Myers <bpm@sgi.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs free the list of recovery items on error.
Date: Wed, 4 Dec 2013 14:51:05 -0600 [thread overview]
Message-ID: <20131204205105.GV1935@sgi.com> (raw)
In-Reply-To: <20131002125409.930462395@sgi.com>
On Wed, Oct 02, 2013 at 07:51:12AM -0500, Mark Tinguely wrote:
> Recovery builds a list of items on the transaction's
> r_itemq head. Normally these items are committed and freed.
> But in the event of a recovery error, these allocations
> are leaked.
>
> If the error occurs during item reordering, then reconstruct
> the r_itemq list before deleting the list to avoid leaking
> the entries that were on one of the temporary lists.
>
> Signed-off-by: Mark Tinguely <tinguely@sgi.com>
Looks good to me.
Reviewed-by: Ben Myers <bpm@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-12-04 20:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 12:51 [PATCH 0/2] misc kernel leak patches Mark Tinguely
2013-10-02 12:51 ` [PATCH 1/2] xfs: fix memory leak in xfs_dir2_node_removename Mark Tinguely
2013-10-02 20:32 ` Dave Chinner
2013-10-02 21:04 ` Mark Tinguely
2013-10-02 12:51 ` [PATCH 2/2] xfs free the list of recovery items on error Mark Tinguely
2013-12-04 20:51 ` Ben Myers [this message]
2013-12-05 22:52 ` Ben Myers
2013-10-02 20:54 ` [PATCH 0/2] misc kernel leak patches Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204205105.GV1935@sgi.com \
--to=bpm@sgi.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.