From: Frederic Weisbecker <fweisbec@gmail.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: tglx@linutronix.de, mingo@kernel.org,
linux-kernel@vger.kernel.org, peterz@infradead.org,
oleg@redhat.com, akpm@linux-foundation.org
Subject: Re: [PATCH 02/10] posix-timers: Remove dead process posix cpu timers caching
Date: Thu, 5 Dec 2013 01:32:03 +0100 [thread overview]
Message-ID: <20131205003201.GB6683@localhost.localdomain> (raw)
In-Reply-To: <529F797A.6010107@jp.fujitsu.com>
On Wed, Dec 04, 2013 at 01:50:34PM -0500, KOSAKI Motohiro wrote:
> > @@ -1090,13 +1063,8 @@ void posix_cpu_timer_schedule(struct k_itimer *timer)
> > timer->it.cpu.expires = 0;
> > goto out_unlock;
> > } else if (unlikely(p->exit_state) && thread_group_empty(p)) {
> > - /*
> > - * We've noticed that the thread is dead, but
> > - * not yet reaped. Take this opportunity to
> > - * drop our task ref.
> > - */
> > + /* Optimizations: if the process is dying, no need to rearm */
> > cpu_timer_sample_group(timer->it_clock, p, &now);
>
> Why do we still need to call cpu_timer_sample_group? You removed to below line which uses
> "now".
Good point, it looks safe to remove it now.
Thanks.
> > - clear_dead_task(timer, now);
> > goto out_unlock;
> > }
> > spin_lock(&p->sighand->siglock);
> >
>
next prev parent reply other threads:[~2013-12-05 0:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-23 15:37 [GIT PULL] posix cpu timers cleanups for 3.14 Frederic Weisbecker
2013-11-23 15:37 ` [PATCH 01/10] posix-timers: Remove dead thread posix cpu timers caching Frederic Weisbecker
2013-11-23 15:37 ` [PATCH 02/10] posix-timers: Remove dead process " Frederic Weisbecker
2013-12-04 18:50 ` KOSAKI Motohiro
2013-12-05 0:32 ` Frederic Weisbecker [this message]
2013-11-23 15:37 ` [PATCH 03/10] posix-timers: Cleanup reaped target handling Frederic Weisbecker
2013-11-23 15:37 ` [PATCH 04/10] posix-timers: Remove dead task special case Frederic Weisbecker
2013-11-23 15:37 ` [PATCH 05/10] posix-timers: Remove useless clock sample on timers cleanup Frederic Weisbecker
2013-11-23 15:37 ` [PATCH 06/10] posix-timers: Consolidate posix_cpu_clock_get() Frederic Weisbecker
2013-11-23 15:37 ` [PATCH 07/10] posix-timers: Use sighand lock instead of tasklist_lock for task clock sample Frederic Weisbecker
2013-11-23 15:37 ` [PATCH 08/10] posix-timers: Use sighand lock instead of tasklist_lock on timer deletion Frederic Weisbecker
2013-11-23 15:37 ` [PATCH 09/10] posix-timers: Remove remaining uses of tasklist_lock Frederic Weisbecker
2013-11-23 15:37 ` [PATCH 10/10] posix-timers: Convert abuses of BUG_ON to WARN_ON Frederic Weisbecker
2013-12-02 15:20 ` [GIT PULL] posix cpu timers cleanups for 3.14 Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205003201.GB6683@localhost.localdomain \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.