From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v6 10/17] serial: mpc512x: setup the PSC FIFO clock as well Date: Wed, 4 Dec 2013 16:55:21 -0800 Message-ID: <20131205005521.GA21377@kroah.com> References: <1385851897-23475-1-git-send-email-gsi@denx.de> <1385851897-23475-11-git-send-email-gsi@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:37394 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933433Ab3LECwq (ORCPT ); Wed, 4 Dec 2013 21:52:46 -0500 Content-Disposition: inline In-Reply-To: <1385851897-23475-11-git-send-email-gsi@denx.de> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Gerhard Sittig Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Anatolij Gustschin , Mike Turquette , Scott Wood , Detlev Zundel , Jiri Slaby , linux-serial@vger.kernel.org On Sat, Nov 30, 2013 at 11:51:30PM +0100, Gerhard Sittig wrote: > prepare and enable the FIFO clock upon PSC FIFO initialization, > check for and propagage errors when enabling the PSC FIFO clock, > disable and unprepare the FIFO clock upon PSC FIFO uninitialization > > devm_{get,put}_clk() doesn't apply here, as the SoC provides a > single FIFO component which is shared among several PSC components, > thus the FIFO isn't associated with a device (while the PSCs are) > > provide a fallback clock lookup approach in case the OF based clock > lookup for the PSC FIFO fails, this allows for successful operation in > the presence of an outdated device tree which lacks clock specs > > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linux-serial@vger.kernel.org > Acked-by: Greg Kroah-Hartman # for v4 > Signed-off-by: Gerhard Sittig > --- > Greg, the addition since v4 is the clk_get_sys() call for the 'ipg' > clock item (backwards compat for device trees w/o clock specs) That's fine, my ACK still stands. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by ozlabs.org (Postfix) with ESMTP id 873072C0092 for ; Thu, 5 Dec 2013 13:52:47 +1100 (EST) Date: Wed, 4 Dec 2013 16:55:21 -0800 From: Greg Kroah-Hartman To: Gerhard Sittig Subject: Re: [PATCH v6 10/17] serial: mpc512x: setup the PSC FIFO clock as well Message-ID: <20131205005521.GA21377@kroah.com> References: <1385851897-23475-1-git-send-email-gsi@denx.de> <1385851897-23475-11-git-send-email-gsi@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1385851897-23475-11-git-send-email-gsi@denx.de> Cc: Mike Turquette , Detlev Zundel , Jiri Slaby , linux-serial@vger.kernel.org, Scott Wood , Anatolij Gustschin , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, Nov 30, 2013 at 11:51:30PM +0100, Gerhard Sittig wrote: > prepare and enable the FIFO clock upon PSC FIFO initialization, > check for and propagage errors when enabling the PSC FIFO clock, > disable and unprepare the FIFO clock upon PSC FIFO uninitialization > > devm_{get,put}_clk() doesn't apply here, as the SoC provides a > single FIFO component which is shared among several PSC components, > thus the FIFO isn't associated with a device (while the PSCs are) > > provide a fallback clock lookup approach in case the OF based clock > lookup for the PSC FIFO fails, this allows for successful operation in > the presence of an outdated device tree which lacks clock specs > > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linux-serial@vger.kernel.org > Acked-by: Greg Kroah-Hartman # for v4 > Signed-off-by: Gerhard Sittig > --- > Greg, the addition since v4 is the clk_get_sys() call for the 'ipg' > clock item (backwards compat for device trees w/o clock specs) That's fine, my ACK still stands. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Date: Wed, 4 Dec 2013 16:55:21 -0800 Subject: [PATCH v6 10/17] serial: mpc512x: setup the PSC FIFO clock as well In-Reply-To: <1385851897-23475-11-git-send-email-gsi@denx.de> References: <1385851897-23475-1-git-send-email-gsi@denx.de> <1385851897-23475-11-git-send-email-gsi@denx.de> Message-ID: <20131205005521.GA21377@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Nov 30, 2013 at 11:51:30PM +0100, Gerhard Sittig wrote: > prepare and enable the FIFO clock upon PSC FIFO initialization, > check for and propagage errors when enabling the PSC FIFO clock, > disable and unprepare the FIFO clock upon PSC FIFO uninitialization > > devm_{get,put}_clk() doesn't apply here, as the SoC provides a > single FIFO component which is shared among several PSC components, > thus the FIFO isn't associated with a device (while the PSCs are) > > provide a fallback clock lookup approach in case the OF based clock > lookup for the PSC FIFO fails, this allows for successful operation in > the presence of an outdated device tree which lacks clock specs > > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linux-serial at vger.kernel.org > Acked-by: Greg Kroah-Hartman # for v4 > Signed-off-by: Gerhard Sittig > --- > Greg, the addition since v4 is the clk_get_sys() call for the 'ipg' > clock item (backwards compat for device trees w/o clock specs) That's fine, my ACK still stands. thanks, greg k-h