From: Matthew Garrett <mjg59@srcf.ucam.org>
To: AceLan Kao <acelan.kao@canonical.com>
Cc: linux-acpi@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch
Subject: Re: [PATCH] ACPI / video: Use native backlight control interface by default
Date: Thu, 5 Dec 2013 02:32:37 +0000 [thread overview]
Message-ID: <20131205023237.GA23671@srcf.ucam.org> (raw)
In-Reply-To: <1386209037-31349-1-git-send-email-acelan.kao@canonical.com>
We had problems with the Intel backlight driver the last time we tried
this, so let's push this through their tree for testing first? Cc:ed
intel-gfx and Daniel Vetter.
On Thu, Dec 05, 2013 at 10:03:57AM +0800, AceLan Kao wrote:
> The native/vendor backlight control interface is hardly fail to control the
> brightness, and we had encountered many backlight issues result from the broken
> ACPI backlight interface, so I think we should promote the native backlight
> control interface and use it by default.
>
> Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
> ---
> drivers/acpi/video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index 995e91b..b3032f8 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -85,7 +85,7 @@ module_param(allow_duplicates, bool, 0644);
> * For Windows 8 systems: if set ture and the GPU driver has
> * registered a backlight interface, skip registering ACPI video's.
> */
> -static bool use_native_backlight = false;
> +static bool use_native_backlight = true;
> module_param(use_native_backlight, bool, 0644);
>
> static int register_count;
> --
> 1.8.3.2
>
>
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2013-12-05 2:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 2:03 [PATCH] ACPI / video: Use native backlight control interface by default AceLan Kao
2013-12-05 2:32 ` Matthew Garrett [this message]
2013-12-05 7:50 ` Daniel Vetter
2013-12-20 6:32 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205023237.GA23671@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=acelan.kao@canonical.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.