From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: lots of brief rcu stalls.
Date: Wed, 4 Dec 2013 18:43:55 -0800 [thread overview]
Message-ID: <20131205024355.GK15492@linux.vnet.ibm.com> (raw)
In-Reply-To: <1386209910.30495.146.camel@edumazet-glaptop2.roam.corp.google.com>
On Wed, Dec 04, 2013 at 06:18:30PM -0800, Eric Dumazet wrote:
> On Wed, 2013-12-04 at 16:16 -0800, Paul E. McKenney wrote:
> > + if (rdp->rsp == rcu_state &&
> > + ULONG_CMP_GE(ACCESS_ONCE(jiffies), rdp->rsp->jiffies_resched)) {
> > + rdp->rsp->jiffies_resched += 5;
> > + resched_cpu(rdp->cpu);
> > + }
> > +
> > return 0;
> > }
>
> jiffies should not need ACCESS_ONCE(), right ?
>
> It is one of the few variables marked with volatile keyword.
Good point! I have queued a patch fixing this and four other occurrences
with your Submitted-by.
Thanx, Paul
prev parent reply other threads:[~2013-12-05 2:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 23:28 lots of brief rcu stalls Dave Jones
2013-12-05 0:16 ` Paul E. McKenney
2013-12-05 1:22 ` Dave Jones
2013-12-05 2:44 ` Paul E. McKenney
2013-12-05 16:49 ` Paul E. McKenney
2013-12-05 17:15 ` Dave Jones
2013-12-05 17:31 ` Paul E. McKenney
2013-12-05 2:18 ` Eric Dumazet
2013-12-05 2:36 ` Joe Perches
2013-12-05 2:51 ` Paul E. McKenney
2013-12-05 2:43 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205024355.GK15492@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=davej@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.