From: Thierry Reding <thierry.reding@gmail.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Jay Agarwal <jagarwal@nvidia.com>,
Pratyush Anand <pratyush.anand@st.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Stephen Warren <swarren@nvidia.com>,
Thierry Reding <treding@nvidia.com>,
Krishna Thota <kthota@nvidia.com>
Subject: Re: [Discussion]: ARM: PCIE: Setup bridges not happening with portbus driver enabled
Date: Thu, 5 Dec 2013 10:12:58 +0100 [thread overview]
Message-ID: <20131205091257.GA13010@ulmo.nvidia.com> (raw)
In-Reply-To: <CAE9FiQUqnSYFnmETkJcSeFh=5S9Qh5XsCuvA1YoXkU4608cXmQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]
On Thu, Dec 05, 2013 at 12:27:40AM -0800, Yinghai Lu wrote:
> On Wed, Dec 4, 2013 at 11:38 PM, Jay Agarwal <jagarwal@nvidia.com> wrote:
> >> On Thu, Dec 05, 2013 at 01:44:53PM +0800, Jay Agarwal wrote:
> >> > I am seeing below issue on an ARM platform with CONFIG_PCIEPORTBUS
> >> > enabled in kernel
> >> >
> >> > ISSUE: Any memory access by devices fails
> >> >
> >> > FINDINGS:
> >> >
> >> > 1. No bridge windows like below are setup and probably this is not
> >> > allowing any memory access by devices
> >>
> >> Does your RC driver calls pci_assign_unassigned_resources after
> >> pci_common_init?
> >>
> > No it does not. Btw, I tried calling it but it also did not help and same problem.
>
> Please make sure you pci_assign_unassigned_resources get called via
> fs_initcall().
Why does this have to be called as fs_initcall() time? Does it have to
be exactly then or can it be at any later time?
The Tegra PCIe driver is actually a regular driver, and run at the time
of device_initcall(). In fact it may even be probed much later because
it can depend on regulators and such that only become available later
and therefore cause the PCIe driver to defer it's probe.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-05 9:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 5:44 [Discussion]: ARM: PCIE: Setup bridges not happening with portbus driver enabled Jay Agarwal
2013-12-05 6:48 ` Pratyush Anand
2013-12-05 7:38 ` Jay Agarwal
2013-12-05 8:27 ` Yinghai Lu
2013-12-05 8:41 ` Jay Agarwal
2013-12-05 9:12 ` Thierry Reding [this message]
2013-12-05 22:50 ` Yinghai Lu
2013-12-05 18:54 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205091257.GA13010@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=bhelgaas@google.com \
--cc=jagarwal@nvidia.com \
--cc=kthota@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=pratyush.anand@st.com \
--cc=swarren@nvidia.com \
--cc=treding@nvidia.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.