From: Steffen Klassert <steffen.klassert@secunet.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: Christophe Gouault <christophe.gouault@6wind.com>,
network dev <netdev@vger.kernel.org>,
Cong Wang <xiyou.wangcong@gmail.com>,
Saurabh Mohan <saurabh.mohan@vyatta.com>
Subject: Re: [PATCH] vti: remove GRE_KEY flag for vti tunnel
Date: Thu, 5 Dec 2013 11:58:57 +0100 [thread overview]
Message-ID: <20131205105857.GV31491@secunet.com> (raw)
In-Reply-To: <20131205094741.GR1258@localhost.localdomain>
On Thu, Dec 05, 2013 at 05:47:41PM +0800, Hangbin Liu wrote:
> On Wed, Dec 04, 2013 at 01:46:40PM +0100, Christophe Gouault wrote:
> > Hello Hangbin,
> >
> > vti interfaces precisely need an o_key to be configured (it must be set
> > to the mark of ipsec policies attached to this interface). Consequently,
> > this flag must not be removed.
>
> I saw the o_key was used here, do you mean this? I'm not clearly understand
> xfrm4_policy_check(), does it really need GRE_KEY? or any value is ok?
It does not need GRE_KEY at all, this flag is not even set on vti
tunnels. The vti key is just a mark that will be set on the skb.
It is used to match the right policy for that tunnel, so the policy
that should match must be configured to have the same mark.
prev parent reply other threads:[~2013-12-05 10:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 8:48 [PATCH] vti: remove GRE_KEY flag for vti tunnel Hangbin Liu
2013-12-04 12:46 ` Christophe Gouault
2013-12-05 8:47 ` Steffen Klassert
2013-12-05 9:47 ` Hangbin Liu
2013-12-05 10:51 ` Steffen Klassert
2013-12-05 16:15 ` Hangbin Liu
2013-12-05 9:47 ` Hangbin Liu
2013-12-05 10:58 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205105857.GV31491@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=christophe.gouault@6wind.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=saurabh.mohan@vyatta.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.