From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: enable EDAC on arm64
Date: Thu, 5 Dec 2013 11:51:42 +0000 [thread overview]
Message-ID: <20131205115142.GD17165@arm.com> (raw)
In-Reply-To: <CAL_JsqJLf-kjzafMJ=wh_ZZa63SOMKy20M_5xjy9GRdofiZVCA@mail.gmail.com>
On Thu, Dec 05, 2013 at 12:53:33AM +0000, Rob Herring wrote:
> On Tue, Nov 26, 2013 at 9:37 AM, Catalin Marinas
> <catalin.marinas@arm.com> wrote:
> > On Fri, Nov 22, 2013 at 09:05:08PM +0000, Rob Herring wrote:
> >> +static inline void atomic_scrub(void *va, u32 size)
> >> +{
> >> + unsigned int *virt_addr = va;
> >> + unsigned int i;
> >> +
> >> + for (i = 0; i < size / sizeof(*virt_addr); i++, virt_addr++) {
> >
> > BTW, maybe the compiler is smart enough to drop the i but why not just
> > use a int *last_addr = va + size - 3; and just compare against this?
>
> Evidently, the compiler is not that smart. Here's what I ended up
> with. There's no need to subtract 3 that I can see:
>
> unsigned int *last_addr = va + size;
> for (; virt_addr < last_addr; virt_addr++) {
The 3 thing was for size not multiple of 4. Do we have any guarantees
here?
--
Catalin
next prev parent reply other threads:[~2013-12-05 11:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 21:05 [PATCH v2] arm64: enable EDAC on arm64 Rob Herring
2013-11-25 18:20 ` Will Deacon
2013-11-26 15:24 ` Rob Herring
2013-11-26 15:37 ` Catalin Marinas
2013-12-05 0:53 ` Rob Herring
2013-12-05 11:51 ` Catalin Marinas [this message]
2013-12-05 13:52 ` Rob Herring
2013-12-05 15:34 ` Catalin Marinas
2014-04-10 13:10 ` Tomasz Nowicki
2014-04-14 22:21 ` Rohit Vaswani
2014-04-21 16:19 ` Rob Herring
2014-04-22 13:01 ` Tomasz Nowicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205115142.GD17165@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.