From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH RFC 2/3] list_lru: add a new LRU_SKIP_REST lru_status value and handling
Date: Thu, 5 Dec 2013 05:30:08 -0800 [thread overview]
Message-ID: <20131205133008.GD3381@infradead.org> (raw)
In-Reply-To: <1386241253-5781-3-git-send-email-jlayton@redhat.com>
On Thu, Dec 05, 2013 at 06:00:52AM -0500, Jeff Layton wrote:
> The current list_lru_walk_node implementation always walks the entire
> list. In some cases, we can be sure that when an entry isn't freeable
> that none of the rest of the entries on the list will be either.
>
> Create a new LRU_SKIP_REST return value that not only indicates that
> the current entry was skipped, but that caller should stop scanning
> the current node.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
I'd call it LRU_DONE, but otherwise this looks fine to me.
next prev parent reply other threads:[~2013-12-05 13:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 11:00 [PATCH RFC 0/3] nfsd: convert nfsd DRC code to use list_lru infrastructure Jeff Layton
2013-12-05 11:00 ` [PATCH RFC 1/3] nfsd: don't try to reuse an expired DRC entry off the list Jeff Layton
2013-12-05 13:29 ` Christoph Hellwig
2013-12-05 13:41 ` Jeff Layton
2013-12-05 15:50 ` J. Bruce Fields
2013-12-05 16:22 ` Jeff Layton
2013-12-05 11:00 ` [PATCH RFC 2/3] list_lru: add a new LRU_SKIP_REST lru_status value and handling Jeff Layton
2013-12-05 13:30 ` Christoph Hellwig [this message]
2013-12-05 13:36 ` Jeff Layton
2013-12-05 11:00 ` [PATCH RFC 3/3] nfsd: convert DRC code to use list_lru Jeff Layton
2013-12-05 13:41 ` Christoph Hellwig
2013-12-05 13:48 ` Jeff Layton
2013-12-05 15:58 ` J. Bruce Fields
2013-12-11 16:31 ` J. Bruce Fields
2013-12-05 13:27 ` [PATCH RFC 0/3] nfsd: convert nfsd DRC code to use list_lru infrastructure Christoph Hellwig
2013-12-05 13:37 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205133008.GD3381@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=dchinner@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.