From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= Subject: Re: [PATCH v2] drm: don't double-free on driver load error Date: Thu, 5 Dec 2013 16:01:43 +0100 Message-ID: <20131205160143.50380ea1@pluto.restena.lu> References: <1386254569-28477-1-git-send-email-imirkin@alum.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtprelay.restena.lu (smtprelay.restena.lu [158.64.1.62]) by gabe.freedesktop.org (Postfix) with ESMTP id 15E15FBA26 for ; Thu, 5 Dec 2013 07:01:46 -0800 (PST) In-Reply-To: <1386254569-28477-1-git-send-email-imirkin@alum.mit.edu> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Ilia Mirkin Cc: Dave Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgSWxpYSwKCk9uIFRodSwgIDUgRGVjIDIwMTMgMDk6NDI6NDkgLTA1MDAgSWxpYSBNaXJraW4g d3JvdGU6Cj4gQWxsIGluc3RhbmNlcyBvZiBkcm1fZGV2X3JlZ2lzdGVyIGFyZSBmb2xsb3dlZCBi eSBkcm1fZGV2X2ZyZWUgb24KPiBmYWlsdXJlLiBEb24ndCBmcmVlIGRldi0+Y29udHJvbC9yZW5k ZXIvcHJpbWFyeSBvbiBmYWlsdXJlLCBhcyB0aGV5IHdpbGwKPiBiZSBmcmVlZCBieSBkcm1fZGV2 X2ZyZWUgc2luY2UgY29tbWl0IDhmNjU5OWRhOGUgKGRybTogZGVsYXkgbWlub3IKPiBkZXN0cnVj dGlvbiB0byBkcm1fZGV2X2ZyZWUoKSkuIEluc3RlYWQgdW5wbHVnIHRoZW0uCgpUaGlzIHBhdGNo IHByZXZlbnRzIHRoZSByZXBvcnRlZCBHUEYgZm9yIDMuMTMtcmMyIG9uIG15IE1CQTIsMQp3aXRo IEdlRm9yY2UgOTQwME0uCgpTbwogIFJlcG9ydGVkLWFuZC10ZXN0ZWQtYnk6IEJydW5vIFByw6lt b250IDxib25ib25zQGxpbnV4LXZzZXJ2ZXIub3JnPgoKClJlc3VsdGluZyBkbWVzZyBpczoKLi4u ClsgICAzNC4xNzkxMzZdIEFDUEkgV2FybmluZzogXF9TQl8uUENJMC5JWFZFLklHUFUuX0RTTTog QXJndW1lbnQgIzQgdHlwZSBtaXNtYXRjaCAtIEZvdW5kIFtJbnRlZ2VyXSwgQUNQSSByZXF1aXJl cyBbUGFja2FnZV0gKDIwMTMxMTE1L25zYXJndW1lbnRzLTk1KQpbICAgMzQuMTc5MzE1XSBBQ1BJ IFdhcm5pbmc6IFxfU0JfLlBDSTAuSVhWRS5JR1BVLl9EU006IEFyZ3VtZW50ICM0IHR5cGUgbWlz bWF0Y2ggLSBGb3VuZCBbQnVmZmVyXSwgQUNQSSByZXF1aXJlcyBbUGFja2FnZV0gKDIwMTMxMTE1 L25zYXJndW1lbnRzLTk1KQpbICAgMzQuMTc5NDc4XSBjaGVja2luZyBnZW5lcmljICg4MDAxMDAw MCA2NDAwMDApIHZzIGh3ICg4MDAwMDAwMCAxMDAwMDAwMCkKWyAgIDM0LjE3OTQ4MV0gZmI6IGNv bmZsaWN0aW5nIGZiIGh3IHVzYWdlIG5vdXZlYXVmYiB2cyBFRkkgVkdBIC0gcmVtb3ZpbmcgZ2Vu ZXJpYyBkcml2ZXIKWyAgIDM0LjE3OTU4N10gQ29uc29sZTogc3dpdGNoaW5nIHRvIGNvbG91ciBk dW1teSBkZXZpY2UgODB4MjUKWyAgIDM0LjE3OTg0MV0gbm91dmVhdSAwMDAwOjAyOjAwLjA6IGVu YWJsaW5nIGRldmljZSAoMDAwNiAtPiAwMDA3KQpbICAgMzQuMTgxMzMwXSBBQ1BJOiBQQ0kgSW50 ZXJydXB0IExpbmsgW0xHUFVdIGVuYWJsZWQgYXQgSVJRIDE2ClsgICAzNC4xODE1NDldIFtkcm1d IGhkbWkgZGV2aWNlICBub3QgZm91bmQgMiAwIDEKWyAgIDM0LjE4MjA0MV0gbm91dmVhdSAgWyAg REVWSUNFXVswMDAwOjAyOjAwLjBdIEJPT1QwICA6IDB4MGFjODAwYjEKWyAgIDM0LjE4MjA0NF0g bm91dmVhdSAgWyAgREVWSUNFXVswMDAwOjAyOjAwLjBdIENoaXBzZXQ6IE1DUDc5L01DUDdBIChO VkFDKQpbICAgMzQuMTgyMDQ3XSBub3V2ZWF1ICBbICBERVZJQ0VdWzAwMDA6MDI6MDAuMF0gRmFt aWx5IDogTlY1MApbICAgMzQuMTg5MzEzXSBub3V2ZWF1ICBbICAgVkJJT1NdWzAwMDA6MDI6MDAu MF0gY2hlY2tpbmcgUFJBTUlOIGZvciBpbWFnZS4uLgpbICAgMzQuMjQ3MzUxXSBub3V2ZWF1ICBb ICAgVkJJT1NdWzAwMDA6MDI6MDAuMF0gLi4uIGFwcGVhcnMgdG8gYmUgdmFsaWQKWyAgIDM0LjI0 NzM1NV0gbm91dmVhdSAgWyAgIFZCSU9TXVswMDAwOjAyOjAwLjBdIHVzaW5nIGltYWdlIGZyb20g UFJBTUlOClsgICAzNC4yNDc1MjFdIG5vdXZlYXUgIFsgICBWQklPU11bMDAwMDowMjowMC4wXSBC SVQgc2lnbmF0dXJlIGZvdW5kClsgICAzNC4yNDc1MjVdIG5vdXZlYXUgIFsgICBWQklPU11bMDAw MDowMjowMC4wXSB2ZXJzaW9uIDYyLjc5LjQ3LjAwLjAxClsgICAzNC4yNjk3NDhdIG5vdXZlYXUg MDAwMDowMjowMC4wOiBpcnEgNDIgZm9yIE1TSS9NU0ktWApbICAgMzQuMjY5ODE2XSBub3V2ZWF1 ICBbICAgICBQTUNdWzAwMDA6MDI6MDAuMF0gTVNJIGludGVycnVwdHMgZW5hYmxlZApbICAgMzQu MjY5OTU2XSBub3V2ZWF1ICBbICAgICBQRkJdWzAwMDA6MDI6MDAuMF0gUkFNIHR5cGU6IHN0b2xl biBzeXN0ZW0gbWVtb3J5ClsgICAzNC4yNjk5NjNdIG5vdXZlYXUgIFsgICAgIFBGQl1bMDAwMDow MjowMC4wXSBSQU0gc2l6ZTogMjU2IE1pQgpbICAgMzQuMjY5OTY5XSBub3V2ZWF1ICBbICAgICBQ RkJdWzAwMDA6MDI6MDAuMF0gICAgWkNPTVA6IDAgdGFncwpbICAgMzQuMzI4OTI0XSBub3V2ZWF1 ICBbICBQVEhFUk1dWzAwMDA6MDI6MDAuMF0gRkFOIGNvbnRyb2w6IG5vbmUgLyBleHRlcm5hbApb ICAgMzQuMzI4OTM1XSBub3V2ZWF1ICBbICBQVEhFUk1dWzAwMDA6MDI6MDAuMF0gZmFuIG1hbmFn ZW1lbnQ6IGF1dG9tYXRpYwpbICAgMzQuMzI4OTM5XSBub3V2ZWF1ICBbICBQVEhFUk1dWzAwMDA6 MDI6MDAuMF0gaW50ZXJuYWwgc2Vuc29yOiB5ZXMKWyAgIDM0LjMyODk0OV0gbm91dmVhdSAgWyAg ICAgQ0xLXVswMDAwOjAyOjAwLjBdIDAzOiBjb3JlIDEwMCBNSHogc2hhZGVyIDIwMCBNSHogClsg ICAzNC4zMjg5NTRdIG5vdXZlYXUgIFsgICAgIENMS11bMDAwMDowMjowMC4wXSAwNTogY29yZSAx NTAgTUh6IHNoYWRlciAzMDAgTUh6IApbICAgMzQuMzI4OTU5XSBub3V2ZWF1ICBbICAgICBDTEtd WzAwMDA6MDI6MDAuMF0gMGU6IGNvcmUgMzAwIE1IeiBzaGFkZXIgNjAwIE1IeiAKWyAgIDM0LjMy ODk2NF0gbm91dmVhdSAgWyAgICAgQ0xLXVswMDAwOjAyOjAwLjBdIDBmOiBjb3JlIDM1MCBNSHog c2hhZGVyIDgwMCBNSHogClsgICAzNC4zMjg5NzhdIG5vdXZlYXUgRVsgICAgIENMS11bMDAwMDow MjowMC4wXSAxNyBmcmVxIHVua25vd24KWyAgIDM0LjMyODk4MF0gbm91dmVhdSBFWyAgICAgQ0xL XVswMDAwOjAyOjAwLjBdIGluaXQgZmFpbGVkLCAtMjIKWyAgIDM0LjMyODk4M10gbm91dmVhdSBF WyAgICAgRFJNXSBmYWlsZWQgdG8gY3JlYXRlIDB4ODAwMDAwODAsIC0yMgpbICAgMzQuMzMxMTA2 XSBub3V2ZWF1OiBwcm9iZSBvZiAwMDAwOjAyOjAwLjAgZmFpbGVkIHdpdGggZXJyb3IgLTIyCgoo dGhlIHByb2JlIGZhaWx1cmUgYmVpbmcgZml4ZWQgYnkgY29tbWl0IG1lbnRpb25lZCBlYXJsaWVy IGluIHRoaXMgdGhyZWFkKQoKVGhhbmtzIGZvciB0aGUgZml4LApCcnVubwoKPiBSZXBvcnRlZC1i eTogQnJ1bm8gUHLDqW1vbnQgPGJvbmJvbnNAbGludXgtdnNlcnZlci5vcmc+Cj4gU2lnbmVkLW9m Zi1ieTogSWxpYSBNaXJraW4gPGltaXJraW5AYWx1bS5taXQuZWR1Pgo+IC0tLQo+IAo+IHYyOiB1 c2UgZHJtX3VucGx1Z19taW5vciBpbnN0ZWFkIG9mIGp1c3QgcmVtb3ZpbmcgdGhlIHB1dHMsIGFz IHN1Z2dlc3RlZCBieQo+ICAgICBEYXZpZCBIZXJybWFuLgo+IAo+ICBkcml2ZXJzL2dwdS9kcm0v ZHJtX3N0dWIuYyB8IDYgKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyks IDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fc3R1 Yi5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9zdHViLmMKPiBpbmRleCBmNTNkNTI0Li42NmRkM2Ew IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fc3R1Yi5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2RybV9zdHViLmMKPiBAQCAtNTY2LDExICs1NjYsMTEgQEAgZXJyX3VubG9hZDoK PiAgCWlmIChkZXYtPmRyaXZlci0+dW5sb2FkKQo+ICAJCWRldi0+ZHJpdmVyLT51bmxvYWQoZGV2 KTsKPiAgZXJyX3ByaW1hcnlfbm9kZToKPiAtCWRybV9wdXRfbWlub3IoZGV2LT5wcmltYXJ5KTsK PiArCWRybV91bnBsdWdfbWlub3IoZGV2LT5wcmltYXJ5KTsKPiAgZXJyX3JlbmRlcl9ub2RlOgo+ IC0JZHJtX3B1dF9taW5vcihkZXYtPnJlbmRlcik7Cj4gKwlkcm1fdW5wbHVnX21pbm9yKGRldi0+ cmVuZGVyKTsKPiAgZXJyX2NvbnRyb2xfbm9kZToKPiAtCWRybV9wdXRfbWlub3IoZGV2LT5jb250 cm9sKTsKPiArCWRybV91bnBsdWdfbWlub3IoZGV2LT5jb250cm9sKTsKPiAgZXJyX2FncDoKPiAg CWlmIChkZXYtPmRyaXZlci0+YnVzLT5hZ3BfZGVzdHJveSkKPiAgCQlkZXYtPmRyaXZlci0+YnVz LT5hZ3BfZGVzdHJveShkZXYpOwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo=