From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC part1 PATCH 5/7] ARM64 / ACPI: Introduce arm_core.c and its related head file Date: Thu, 5 Dec 2013 21:40:42 +0100 Message-ID: <201312052140.42269.arnd@arndb.de> References: <1386088611-2801-1-git-send-email-hanjun.guo@linaro.org> <201312050438.05117.arnd@arndb.de> <52A084EB.5010103@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <52A084EB.5010103@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Hanjun Guo Cc: Mark Rutland , "Rafael J. Wysocki" , linaro-kernel@lists.linaro.org, Russell King - ARM Linux , Al Stone , Graeme Gregory , Matthew Garrett , Catalin Marinas , Linus Walleij , Daniel Lezcano , Will Deacon , linux-kernel@vger.kernel.org, Rob Herring , linaro-acpi@lists.linaro.org, linux-acpi@vger.kernel.org, Jon Masters , patches@linaro.org, Olof Johansson , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Grant Likely List-Id: linux-acpi@vger.kernel.org T24gVGh1cnNkYXkgMDUgRGVjZW1iZXIgMjAxMywgSGFuanVuIEd1byB3cm90ZToKPiBPbiAyMDEz 5bm0MTLmnIgwNeaXpSAxMTozOCwgQXJuZCBCZXJnbWFubiB3cm90ZToKPiA+IE9uIFR1ZXNkYXkg MDMgRGVjZW1iZXIgMjAxMywgSGFuanVuIEd1byB3cm90ZToKPiA+PiArc3RhdGljIHVuc2lnbmVk IGludCBnc2lfdG9faXJxKHVuc2lnbmVkIGludCBnc2kpCj4gPj4gK3sKPiA+PiArICAgICAgIGlu dCBpcnEgPSBpcnFfY3JlYXRlX21hcHBpbmcoTlVMTCwgZ3NpKTsKPiA+PiArCj4gPj4gKyAgICAg ICByZXR1cm4gaXJxOwo+ID4+ICt9Cj4gPiBJIHRoaW5rIHRoaXMgY291bGQgdXNlIGEgY29tbWVu dCByZWdhcmRpbmcgeW91ciBwbGFucyBmb3IgSVJRIGRvbWFpbnMuCj4gPgo+ID4gRG8geW91IGV4 cGVjdCB0aGF0IGFsbCBBQ1BJIHN5c3RlbXMgd291bGQgaGF2ZSBvbmx5IGEgc2luZ2xlIEdJQyBJ UlEKPiA+IGNvbnRyb2xsZXIgYW5kIGEgc2luZ2xlIGRvbWFpbiwgb3IgZG8geW91IHBsYW4gdG8g YWRkIGlycWRvbWFpbiBjb2RlCj4gPiBsYXRlcj8KPiAKPiB3ZSBhZGRlZCBpcnFkb21haW4gY29k ZSBpbiB0aGUgcGFydDIgcGF0Y2ggc2V0LCBpcyB0aGF0IHRoZSBjb2RlIG9rCj4gd2l0aCB5b3U/ CgpJIGRvbid0IHNlZSB3aGVyZSBpdCBnZXRzIGFkZGVkLiBEbyB5b3UgbWVhbiAiW1JGQyBwYXJ0 MiBQQVRDSCA4LzldIEFDUEkgLwpBUk02NDogVXBkYXRlIGFjcGlfcmVnaXN0ZXJfZ3NpIHRvIHJl Z2lzdGVyIHdpdGggdGhlIGNvcmUgSVJRIHN1YnN5c3RlbSI/ClRoYXQgc3RpbGwganVzdCB1c2Vz IGEgc2luZ2xlIGRvbWFpbi4KCldoZW4gd2UgdGFsa2VkIGFib3V0IEFDUEkgc3VwcG9ydCBhdCBM aW5hcm8gY29ubmVjdCwgc29tZW9uZSBtZW50aW9uZWQKdGhhdCB0aGUgQUNQSSBzcGVjIGRvZXMg aGF2ZSB0aGUgY29uY2VwdCBvZiBJUlEgZG9tYWlucywgYnV0IGl0IHNlZW1zCnRoZXkgYXJlIG5v dCBpbXBsZW1lbnRlZCBieSBMaW51eC4KCkhvdyBkbyB5b3UgZ2V0IGEgbWFwcGluZyBmb3IgYW4g SVJRIG9uIGEgc2Vjb25kYXJ5IGlycWNoaXAgc3VjaCBhcwphIEdQSU8gZXh0ZW5kZXI/CgoJQXJu ZAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Thu, 5 Dec 2013 21:40:42 +0100 Subject: [RFC part1 PATCH 5/7] ARM64 / ACPI: Introduce arm_core.c and its related head file In-Reply-To: <52A084EB.5010103@linaro.org> References: <1386088611-2801-1-git-send-email-hanjun.guo@linaro.org> <201312050438.05117.arnd@arndb.de> <52A084EB.5010103@linaro.org> Message-ID: <201312052140.42269.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 05 December 2013, Hanjun Guo wrote: > On 2013?12?05? 11:38, Arnd Bergmann wrote: > > On Tuesday 03 December 2013, Hanjun Guo wrote: > >> +static unsigned int gsi_to_irq(unsigned int gsi) > >> +{ > >> + int irq = irq_create_mapping(NULL, gsi); > >> + > >> + return irq; > >> +} > > I think this could use a comment regarding your plans for IRQ domains. > > > > Do you expect that all ACPI systems would have only a single GIC IRQ > > controller and a single domain, or do you plan to add irqdomain code > > later? > > we added irqdomain code in the part2 patch set, is that the code ok > with you? I don't see where it gets added. Do you mean "[RFC part2 PATCH 8/9] ACPI / ARM64: Update acpi_register_gsi to register with the core IRQ subsystem"? That still just uses a single domain. When we talked about ACPI support at Linaro connect, someone mentioned that the ACPI spec does have the concept of IRQ domains, but it seems they are not implemented by Linux. How do you get a mapping for an IRQ on a secondary irqchip such as a GPIO extender? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752849Ab3LEUlU (ORCPT ); Thu, 5 Dec 2013 15:41:20 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:51703 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739Ab3LEUlR (ORCPT ); Thu, 5 Dec 2013 15:41:17 -0500 From: Arnd Bergmann To: Hanjun Guo Subject: Re: [RFC part1 PATCH 5/7] ARM64 / ACPI: Introduce arm_core.c and its related head file Date: Thu, 5 Dec 2013 21:40:42 +0100 User-Agent: KMail/1.12.2 (Linux/3.8.0-22-generic; KDE/4.3.2; x86_64; ; ) Cc: linux-arm-kernel@lists.infradead.org, "Rafael J. Wysocki" , Catalin Marinas , Will Deacon , "Russell King - ARM Linux" , Daniel Lezcano , Mark Rutland , Matthew Garrett , linaro-kernel@lists.linaro.org, Graeme Gregory , Al Stone , patches@linaro.org, Linus Walleij , Olof Johansson , linux-kernel@vger.kernel.org, Rob Herring , linaro-acpi@lists.linaro.org, linux-acpi@vger.kernel.org, Jon Masters , Grant Likely , Bjorn Helgaas References: <1386088611-2801-1-git-send-email-hanjun.guo@linaro.org> <201312050438.05117.arnd@arndb.de> <52A084EB.5010103@linaro.org> In-Reply-To: <52A084EB.5010103@linaro.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <201312052140.42269.arnd@arndb.de> X-Provags-ID: V02:K0:M6y8Yc8XZNpYlHtYek3ez89PU4TEAEGOdWPWIjPK0ev QPpwWDT3yvs9V8AGCEYIHNZLn7jid9G4ld/GjWNB+bdEnDdGLy dPI+p3HKwJRkpqoHEAEVL0mKQe3aAoPYPm6Rm42udlAqXcgu7z fCt6DAUpU3DdrMdomDutosDPJfE5rSvNSN+LFk7xh1yYGVyJOd tUdjSPYVKHTW0bZkWGIBL7aMAHffVGEs/bGVNY1f5PYFDtEMjU WtLk5vM3JmqXTXoFLlpbVdhY1RNWP61OBOuUSaozRoY08J1jVg Bnov9m8GLG1bHGY7HWmmqaNhz8SCkndMzin6KeMBeYtUUIsaCR z3FGxOra4ZHRuHCmIEWg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 05 December 2013, Hanjun Guo wrote: > On 2013年12月05日 11:38, Arnd Bergmann wrote: > > On Tuesday 03 December 2013, Hanjun Guo wrote: > >> +static unsigned int gsi_to_irq(unsigned int gsi) > >> +{ > >> + int irq = irq_create_mapping(NULL, gsi); > >> + > >> + return irq; > >> +} > > I think this could use a comment regarding your plans for IRQ domains. > > > > Do you expect that all ACPI systems would have only a single GIC IRQ > > controller and a single domain, or do you plan to add irqdomain code > > later? > > we added irqdomain code in the part2 patch set, is that the code ok > with you? I don't see where it gets added. Do you mean "[RFC part2 PATCH 8/9] ACPI / ARM64: Update acpi_register_gsi to register with the core IRQ subsystem"? That still just uses a single domain. When we talked about ACPI support at Linaro connect, someone mentioned that the ACPI spec does have the concept of IRQ domains, but it seems they are not implemented by Linux. How do you get a mapping for an IRQ on a secondary irqchip such as a GPIO extender? Arnd