From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58339)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VowNA-0005Xo-GC
	for qemu-devel@nongnu.org; Fri, 06 Dec 2013 09:27:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VowN5-0006Hf-Gk
	for qemu-devel@nongnu.org; Fri, 06 Dec 2013 09:27:16 -0500
Received: from mx1.redhat.com ([209.132.183.28]:20642)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VowN5-0006HZ-9C
	for qemu-devel@nongnu.org; Fri, 06 Dec 2013 09:27:11 -0500
Date: Fri, 6 Dec 2013 09:27:03 -0500
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20131206092703.5d60345a@redhat.com>
In-Reply-To: <1386263703-19292-5-git-send-email-benoit@irqsave.net>
References: <1386263703-19292-1-git-send-email-benoit@irqsave.net>
	<1386263703-19292-5-git-send-email-benoit@irqsave.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on
 names block driver states.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QmVub8OudA==?= Canet <benoit@irqsave.net>
Cc: kwolf@redhat.com, famz@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com

On Thu,  5 Dec 2013 18:15:00 +0100
Beno=C3=AEt Canet <benoit@irqsave.net> wrote:

> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1675,7 +1675,11 @@
>  # determine which ones are encrypted, set the passwords with this comman=
d, and
>  # then start the guest with the @cont command.
>  #
> -# @device:   the name of the device to set the password on
> +# Either @device or @node-name must be set but not both.
> +#
> +# @device: #optional the name of the block backend device to set the pas=
sword on
> +#
> +# @node-name: #optional graph node name to set the password on (Since 2.=
0)
>  #
>  # @password: the password to use for the device
>  #
> @@ -1689,7 +1693,8 @@
>  #
>  # Since: 0.14.0
>  ##
> -{ 'command': 'block_passwd', 'data': {'device': 'str', 'password': 'str'=
} }
> +{ 'command': 'block_passwd', 'data': {'*device': 'str',
> +                                      '*node-name': 'str', 'password': '=
str'} }

What about:

{ 'command': 'block_passwd', 'data': {'device': 'str',
                                      '*device-is-node': 'bool', 'password'=
: 'str'} }