From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [flasher PATCH V2 3/4] Allow overriding environment variables during flashing
Date: Fri, 6 Dec 2013 20:57:12 +0100 [thread overview]
Message-ID: <20131206195711.GC923@mithrandir> (raw)
In-Reply-To: <1386351334-25766-2-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 998 bytes --]
On Fri, Dec 06, 2013 at 10:35:34AM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> The flashing process resets the U-Boot environment to the built-in
> default. Allow the user to specify some non-default values to be set
> before saving the environment. This can be useful e.g. to set up the
> default boot target:
>
> ./tegra-uboot-flasher flash --env boot_targets dhcp beaver
>
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> v2:
> * Don't fail if no --env cmdline options are used.
> * Enhance help text to:
> - Explicitly mention that the option can be used multiple times.
> (in --help output only, not the short help)
> - Say "--env VAR VALUE" not "--env ENV ENV" so the syntax is clear.
> ---
> tegra-uboot-flasher | 7 +++++++
> 1 file changed, 7 insertions(+)
Looks good:
Reviewed-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-06 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 17:35 [flasher PATCH V2 1/4] Add crc32 verification of the flash image Stephen Warren
[not found] ` <1386351334-25766-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-06 17:35 ` [flasher PATCH V2 3/4] Allow overriding environment variables during flashing Stephen Warren
[not found] ` <1386351334-25766-2-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-06 19:57 ` Thierry Reding [this message]
2013-12-06 19:56 ` [flasher PATCH V2 1/4] Add crc32 verification of the flash image Thierry Reding
2013-12-06 20:01 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206195711.GC923@mithrandir \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.