From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: nand: gpio: Remove unneeded CONFIG_OF
Date: Sat, 7 Dec 2013 12:33:13 -0300 [thread overview]
Message-ID: <20131207153312.GA4273@localhost> (raw)
In-Reply-To: <1386428072.693656580@f164.i.mail.ru>
On Sat, Dec 07, 2013 at 06:54:32PM +0400, Alexander Shiyan wrote:
> Hello.
>
> > Since the of_mtd header provides dummy stubs for !CONFIG_OF, it's safe
> > to remove the #ifdef CONFIG_OF. Build tested only.
> >
> > Cc: Alexander Shiyan <shc_work@mail.ru>
> > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ...
> > -#ifdef CONFIG_OF
> > static const struct of_device_id gpio_nand_id_table[] = {
>
> You should add "__maybe_unused" attribute here in this case.
> This will avoid warning when you build driver without OF.
>
> ---
I don't get such warning, maybe because the GCC is smart enough
to remove the symbol?
Actually, I realise now we don't need to of_match_ptr, so let
me push a v2.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-12-07 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-07 14:48 [PATCH] mtd: nand: gpio: Remove unneeded CONFIG_OF Ezequiel Garcia
2013-12-07 14:54 ` Alexander Shiyan
2013-12-07 15:33 ` Ezequiel Garcia [this message]
2013-12-07 15:35 ` Alexander Shiyan
2013-12-07 15:40 ` Ezequiel Garcia
2013-12-07 15:43 ` Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131207153312.GA4273@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-mtd@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.