Re: [PATCH] PCI: rcar: fix return value check in rcar_pci_probe()

[Bjorn Helgaas <bhelgaas@google.com>]

On Tue, Nov 19, 2013 at 11:40:28AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Applied with Jingoo's reviewed-by to pci/host-rcar for v3.14, thanks!

For drivers/pci/host/*, I normally look for an ack from the responsible
person,  but this patch is trivial enough that I'm fine taking it without
that.  But for more significant changes, I don't have any notes about who
should own pci-rcar-gen2.c.  Valentine could be a candidate since he added
it in the first place?  Or Jingoo?

Bjorn

> ---
>  drivers/pci/host/pci-rcar-gen2.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c
> index cbaa5c4..96d1182 100644
> --- a/drivers/pci/host/pci-rcar-gen2.c
> +++ b/drivers/pci/host/pci-rcar-gen2.c
> @@ -276,8 +276,8 @@ static int __init rcar_pci_probe(struct platform_device *pdev)
>  
>  	cfg_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	reg = devm_ioremap_resource(&pdev->dev, cfg_res);
> -	if (!reg)
> -		return -ENODEV;
> +	if (IS_ERR(reg))
> +		return PTR_ERR(reg);
>  
>  	mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>  	if (!mem_res || !mem_res->start)
>