From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Ivajlo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Ivaylo Dimitrov <freemangordon@abv.bg>,
pavel@ucw.cz, pali.rohar@gmail.com, Joe Perches <joe@perches.com>
Subject: Re: [PATCH] Staging: TIDSPBRIDGE: Remove UUID helper
Date: Sat, 7 Dec 2013 23:18:57 -0800 [thread overview]
Message-ID: <20131208071857.GA12104@kroah.com> (raw)
In-Reply-To: <52A2DF40.9070707@gmail.com>
On Sat, Dec 07, 2013 at 10:41:36AM +0200, Ivajlo Dimitrov wrote:
>
> On 06.12.2013 17:10, gregkh@linuxfoundation.org wrote:
> > On Fri, Dec 06, 2013 at 08:05:38AM +0200, Ivajlo Dimitrov wrote:
> >> Hi Greg,
> >>
> >> On 01.12.2013 19:07, Ivaylo DImitrov wrote:
> >>> From: Ivaylo Dimitrov <freemangordon@abv.bg>
> >>>
> >>> Custom uuid helper function is needed only in rmgr/dbdcd.c and doesn't
> >>> need to be exported. It can also be made way simpler by using sscanf.
> >>>
> >>> Signed-off-by: Ivaylo Dimitrov <freemangordon@abv.bg>
> >>> ---
> >>> drivers/staging/tidspbridge/Makefile | 2 +-
> >>> drivers/staging/tidspbridge/gen/uuidutil.c | 85 --------------------
> >>> .../tidspbridge/include/dspbridge/uuidutil.h | 18 ----
> >>> drivers/staging/tidspbridge/rmgr/dbdcd.c | 42 +++++++++-
> >>> 4 files changed, 39 insertions(+), 108 deletions(-)
> >>> delete mode 100644 drivers/staging/tidspbridge/gen/uuidutil.c
> >>>
> >> I guess the initial mail somehow didn't make it through your spam filter:
> >> https://lkml.org/lkml/2013/12/1/70
> > It did, but I thought that people asked for it to be changed in the
> > thread afterwards, so I was expecting an updated version from you.
> >
> > Care to fix things up and resend it?
> >
> > thanks,
> >
> > greg k-h
>
> Sure, the change I was asked for is trivial, but I didn't get the reason
> why it is needed. Neither there is a reply to my follow-up comment [0].
> Sorry, I am pretty much new on LKML and could miss things that are
> supposed to be clear from the start, but my impression is that when
> someone says "it is better", he/she should explain why it is better or
> at least what is wrong with the patch he/she wants to be changed.
>
> However, I don't want to enter some arguing loop, so if you think I
> should change the code as per Joe's comment, just confirm it and I'll do it.
Please try.
next prev parent reply other threads:[~2013-12-08 7:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-01 17:07 [PATCH] Staging: TIDSPBRIDGE: Remove UUID helper Ivaylo DImitrov
2013-12-01 19:06 ` Joe Perches
2013-12-01 23:26 ` Ivajlo Dimitrov
2013-12-06 6:05 ` Ivajlo Dimitrov
2013-12-06 7:32 ` Dan Carpenter
2013-12-06 7:41 ` Ivajlo Dimitrov
2013-12-06 15:10 ` gregkh
2013-12-07 8:41 ` Ivajlo Dimitrov
2013-12-08 7:18 ` gregkh [this message]
2013-12-08 12:32 ` Pavel Machek
2013-12-09 10:13 ` [PATCH v2] " Ivaylo DImitrov
2013-12-09 14:40 ` Pavel Machek
2013-12-09 18:34 ` Joe Perches
2013-12-10 22:03 ` [PATCH v3] " Ivaylo DImitrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131208071857.GA12104@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=freemangordon@abv.bg \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.