All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ti-wpan: Add new package
Date: Sun, 8 Dec 2013 12:06:59 +0100	[thread overview]
Message-ID: <20131208120659.60042c0d@skate> (raw)
In-Reply-To: <1386495041-17629-1-git-send-email-alexandre.belloni@free-electrons.com>

Dear Alexandre Belloni,

Thanks for this contribution!

On Sun,  8 Dec 2013 10:30:41 +0100, Alexandre Belloni wrote:
> diff --git a/package/ti-wpan/ti-wpan.mk b/package/ti-wpan/ti-wpan.mk
> new file mode 100644
> index 000000000000..ef70495e3342
> --- /dev/null
> +++ b/package/ti-wpan/ti-wpan.mk
> @@ -0,0 +1,25 @@
> +#############################################################
> +#
> +# ti-wpan
> +#
> +#############################################################
> +
> +TI_WPAN_VERSION = 5beae4748cd36f4464a43e0a870c881a3f8f1b5b
> +TI_WPAN_SITE = git://git.omapzoom.org/platform/hardware/ti/wpan.git
> +TI_WPAN_LICENSE = GPLv2+
> +TI_WPAN_LICENSE_FILES = ti_st/uim-sysfs/uim.c
> +
> +define TI_WPAN_BUILD_CMDS
> +    cd $(@D)/ti_st/uim-sysfs && $(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) -o uim-sysfs uim.c 

Would be slightly better to have an indentation of one tab here, like
the other commands below.

> +endef
> +
> +define TI_WPAN_INSTALL_TARGET_CMDS
> +	$(INSTALL) -m 0755 -D $(@D)/ti_st/uim-sysfs/uim-sysfs \
> +		$(TARGET_DIR)/usr/sbin/uim-sysfs
> +endef
> +
> +define TI_WPAN_UNINSTALL_TARGET_CMDS
> +	rm -f $(TARGET_DIR)/usr/sbin/uim-sysfs
> +endef

Please remove the uninstall command. We have deprecated this, and they
have all been removed from the repository a few days ago, so we don't
want to introduce more of them :)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2013-12-08 11:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-08  9:30 [Buildroot] [PATCH] ti-wpan: Add new package Alexandre Belloni
2013-12-08 11:06 ` Thomas Petazzoni [this message]
2013-12-08 11:29   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131208120659.60042c0d@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.