From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH V4] cpufreq: suspend governors on system suspend/hibernate Date: Sun, 8 Dec 2013 13:41:08 +0100 Message-ID: <20131208124108.GA4286@pd.tnic> References: <28d493f20239a242a7b26dfe1efed40d83bf1e10.1385523340.git.viresh.kumar@linaro.org> <87vbz0j55p.fsf@nemi.mork.no> <1386429849.9737.7.camel@x41.thuisdomein> <3466098.C5M665z3nb@vostro.rjw.lan> Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1386506471; bh=0qy9ppUbuR2wJ8Rwwrv8pOUOGsdDs/S9UU9ss+SuleQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Transfer-Encoding:In-Reply-To; b=IdZnRzYXmWVU LwyCeSmKuTu4CbbQeLX1EA4beXaZNxlx2ZU39gYduFUXiRYmerZPD+wwDNMrpDDFkEG n4rc68suYH8sEe13SxWYQprSET+YhH2JUYeVlHfZh3b43x4VqXheQjAwi+ugsxFkSBj sQVCZXZrp6aHnmRywVfQLu170= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1386506470; bh=0qy9ppUbuR2wJ8Rwwrv8pOUOGsdDs/S9UU9ss+SuleQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Transfer-Encoding:In-Reply-To; b=hj9CZLQe/ZpQ gP59PduRlEIOfYx1L2vSunsPSj7+MHbBuwqOK00NjmACQxk5lPQxqzR6BaWq3nqR5IE QoFr5cmtmidFisF/MXWB9Uex2W9H5eM1KbSn3yH1cfNZZMzbGT31LFdy/ZH5fbIXNkv kqytjtJiXQkSYZ7PQFe9P7JTM= Content-Disposition: inline In-Reply-To: <3466098.C5M665z3nb-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="iso-8859-1" To: "Rafael J. Wysocki" Cc: Paul Bolle , =?utf-8?B?QmrDuHJu?= Mork , Viresh Kumar , Lists linaro-kernel , Patch Tracking , "cpufreq-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux Kernel Mailing List , Nishanth Menon , Stephen Warren , Kgene Kim , linux-samsung-soc , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jinchoi-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Lan Tianyu , Sebastian Capella , Jonghwan Choi On Sun, Dec 08, 2013 at 01:34:36AM +0100, Rafael J. Wysocki wrote: > On Saturday, December 07, 2013 04:24:09 PM Paul Bolle wrote: > > On Sat, 2013-12-07 at 12:01 +0100, Bj=C3=B8rn Mork wrote: > > > Sorry to be making noise here again, but I was eager to verify th= at the > > > fixes in v3.13-rc3 were OK on my system. Unfortunately it seems = this > > > patch completely broke suspend for me. Hibernete ended up with a= blank > > > console and no visible activity, without ever writing any image t= o disk. > > >=20 > > > There really weren't that many suspects between v3.13-rc2 and v3.= 13-rc3, > > > so I went directly to reverting 5a87182aa21d ("cpufreq: suspend > > > governors on system suspend/hibernate") which fixed the problem. = I > > > didn't bother debugging it further from there. I don't think ther= e is > > > anything magic about my system which should make this problem spe= cific > > > to it. > > >=20 > > > I am still using the acpi-cpufreq driver on an old x86_64 laptop = if that > > > matters. > >=20 > > On an x86 (32 bits) laptop hibernate also broke in v3.13-rc3. On th= at > > machine hibernation itself worked, or at least seemed to work, but = the > > machine would basically stop after thawing (directly after loading = the > > hibernation image). > >=20 > > And reverting commit 5a87182aa21d ("cpufreq: suspend governors on s= ystem > > suspend/hibernate"), on top of v3.13-rc3, also lead to a successful > > hibernation/thaw cycle. >=20 > OK, reverted. +1. Grrr, I just wasted a whole morning bisecting the same issue as reporte= d above and can confirm the revert is the right thing to do. Well, almost: the box almost suspends until I hear the clicking sound o= f the mainboard trying to turn stuff off but then the fan remains on. Whe= n I hit a button on the keyboard, it then turns off completely. This is probably some nasty BIOS SMI crap which we don't have control over and I'd guess unrelated to the issue at hand. Anyway, Rafael, I was wondering: I have a couple of boxes here and it would probably make a good sense to help out with testing this stuff more - I just can't have suspend breakages. Maybe you'd like me to give a run of your tree now and then to check whether someone has sent you a quickly rushed brownpaper bag of questionable nature and we can fish it out before it hits Linus. :) So let me know. Thanks. --=20 Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH V4] cpufreq: suspend governors on system suspend/hibernate Date: Sun, 8 Dec 2013 13:41:08 +0100 Message-ID: <20131208124108.GA4286@pd.tnic> References: <28d493f20239a242a7b26dfe1efed40d83bf1e10.1385523340.git.viresh.kumar@linaro.org> <87vbz0j55p.fsf@nemi.mork.no> <1386429849.9737.7.camel@x41.thuisdomein> <3466098.C5M665z3nb@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <3466098.C5M665z3nb-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Rafael J. Wysocki" Cc: Paul Bolle , =?utf-8?B?QmrDuHJu?= Mork , Viresh Kumar , Lists linaro-kernel , Patch Tracking , "cpufreq-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux Kernel Mailing List , Nishanth Menon , Stephen Warren , Kgene Kim , linux-samsung-soc , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jinchoi-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Lan Tianyu , Sebastian Capella , Jonghwan Choi List-Id: linux-pm@vger.kernel.org On Sun, Dec 08, 2013 at 01:34:36AM +0100, Rafael J. Wysocki wrote: > On Saturday, December 07, 2013 04:24:09 PM Paul Bolle wrote: > > On Sat, 2013-12-07 at 12:01 +0100, Bj=C3=B8rn Mork wrote: > > > Sorry to be making noise here again, but I was eager to verify th= at the > > > fixes in v3.13-rc3 were OK on my system. Unfortunately it seems = this > > > patch completely broke suspend for me. Hibernete ended up with a= blank > > > console and no visible activity, without ever writing any image t= o disk. > > >=20 > > > There really weren't that many suspects between v3.13-rc2 and v3.= 13-rc3, > > > so I went directly to reverting 5a87182aa21d ("cpufreq: suspend > > > governors on system suspend/hibernate") which fixed the problem. = I > > > didn't bother debugging it further from there. I don't think ther= e is > > > anything magic about my system which should make this problem spe= cific > > > to it. > > >=20 > > > I am still using the acpi-cpufreq driver on an old x86_64 laptop = if that > > > matters. > >=20 > > On an x86 (32 bits) laptop hibernate also broke in v3.13-rc3. On th= at > > machine hibernation itself worked, or at least seemed to work, but = the > > machine would basically stop after thawing (directly after loading = the > > hibernation image). > >=20 > > And reverting commit 5a87182aa21d ("cpufreq: suspend governors on s= ystem > > suspend/hibernate"), on top of v3.13-rc3, also lead to a successful > > hibernation/thaw cycle. >=20 > OK, reverted. +1. Grrr, I just wasted a whole morning bisecting the same issue as reporte= d above and can confirm the revert is the right thing to do. Well, almost: the box almost suspends until I hear the clicking sound o= f the mainboard trying to turn stuff off but then the fan remains on. Whe= n I hit a button on the keyboard, it then turns off completely. This is probably some nasty BIOS SMI crap which we don't have control over and I'd guess unrelated to the issue at hand. Anyway, Rafael, I was wondering: I have a couple of boxes here and it would probably make a good sense to help out with testing this stuff more - I just can't have suspend breakages. Maybe you'd like me to give a run of your tree now and then to check whether someone has sent you a quickly rushed brownpaper bag of questionable nature and we can fish it out before it hits Linus. :) So let me know. Thanks. --=20 Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755341Ab3LHMlR (ORCPT ); Sun, 8 Dec 2013 07:41:17 -0500 Received: from mail.skyhub.de ([78.46.96.112]:39767 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751617Ab3LHMlM (ORCPT ); Sun, 8 Dec 2013 07:41:12 -0500 Date: Sun, 8 Dec 2013 13:41:08 +0100 From: Borislav Petkov To: "Rafael J. Wysocki" Cc: Paul Bolle , =?utf-8?B?QmrDuHJu?= Mork , Viresh Kumar , Lists linaro-kernel , Patch Tracking , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , Nishanth Menon , Stephen Warren , Kgene Kim , linux-samsung-soc , linux-tegra@vger.kernel.org, jinchoi@broadcom.com, Lan Tianyu , Sebastian Capella , Jonghwan Choi Subject: Re: [PATCH V4] cpufreq: suspend governors on system suspend/hibernate Message-ID: <20131208124108.GA4286@pd.tnic> References: <28d493f20239a242a7b26dfe1efed40d83bf1e10.1385523340.git.viresh.kumar@linaro.org> <87vbz0j55p.fsf@nemi.mork.no> <1386429849.9737.7.camel@x41.thuisdomein> <3466098.C5M665z3nb@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3466098.C5M665z3nb@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 08, 2013 at 01:34:36AM +0100, Rafael J. Wysocki wrote: > On Saturday, December 07, 2013 04:24:09 PM Paul Bolle wrote: > > On Sat, 2013-12-07 at 12:01 +0100, Bjørn Mork wrote: > > > Sorry to be making noise here again, but I was eager to verify that the > > > fixes in v3.13-rc3 were OK on my system. Unfortunately it seems this > > > patch completely broke suspend for me. Hibernete ended up with a blank > > > console and no visible activity, without ever writing any image to disk. > > > > > > There really weren't that many suspects between v3.13-rc2 and v3.13-rc3, > > > so I went directly to reverting 5a87182aa21d ("cpufreq: suspend > > > governors on system suspend/hibernate") which fixed the problem. I > > > didn't bother debugging it further from there. I don't think there is > > > anything magic about my system which should make this problem specific > > > to it. > > > > > > I am still using the acpi-cpufreq driver on an old x86_64 laptop if that > > > matters. > > > > On an x86 (32 bits) laptop hibernate also broke in v3.13-rc3. On that > > machine hibernation itself worked, or at least seemed to work, but the > > machine would basically stop after thawing (directly after loading the > > hibernation image). > > > > And reverting commit 5a87182aa21d ("cpufreq: suspend governors on system > > suspend/hibernate"), on top of v3.13-rc3, also lead to a successful > > hibernation/thaw cycle. > > OK, reverted. +1. Grrr, I just wasted a whole morning bisecting the same issue as reported above and can confirm the revert is the right thing to do. Well, almost: the box almost suspends until I hear the clicking sound of the mainboard trying to turn stuff off but then the fan remains on. When I hit a button on the keyboard, it then turns off completely. This is probably some nasty BIOS SMI crap which we don't have control over and I'd guess unrelated to the issue at hand. Anyway, Rafael, I was wondering: I have a couple of boxes here and it would probably make a good sense to help out with testing this stuff more - I just can't have suspend breakages. Maybe you'd like me to give a run of your tree now and then to check whether someone has sent you a quickly rushed brownpaper bag of questionable nature and we can fish it out before it hits Linus. :) So let me know. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --