All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "ethan.zhao" <ethan.kernel@gmail.com>
Cc: konrad.wilk@oracle.com, raghavendra.kt@linux.vnet.ibm.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen/debugfs: Check debugfs initialization before using it
Date: Sun, 8 Dec 2013 06:01:00 -0800	[thread overview]
Message-ID: <20131208140100.GA22793@kroah.com> (raw)
In-Reply-To: <1386502262-1163-1-git-send-email-ethan.kernel@gmail.com>

On Sun, Dec 08, 2013 at 07:31:02PM +0800, ethan.zhao wrote:
> Should check debugfs initialization with debugfs_initialized() before using it,
> Because if it isn't initialized, the return value of fake debugfs_create_dir() etc
> functions would be ERR_PTR(-ENODEV), checking with NULL will not work.

So?  It should "just work" without this check, right?  What happens if
your patch isn't applied and debugfs isn't enabled?

greg k-h

> Signed-off-by: ethan.zhao <ethan.kernel@gmail.com>

Please put your "real" name here, not one with a '.' in it.

thanks,

greg k-h

  reply	other threads:[~2013-12-08 13:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-08 11:31 [PATCH] xen/debugfs: Check debugfs initialization before using it ethan.zhao
2013-12-08 14:01 ` Greg KH [this message]
2013-12-09  1:43   ` Ethan Zhao
2013-12-09  8:25     ` Greg KH
2013-12-09  8:44       ` Ethan Zhao
2013-12-09  8:55         ` Greg KH
2013-12-09  9:57           ` Ethan Zhao
2013-12-09 11:17             ` Greg KH
2013-12-09 13:42               ` Ethan Zhao
2013-12-09 18:40                 ` Greg KH
2013-12-10  8:03                   ` Ethan Zhao
2013-12-10  8:19                     ` Greg KH
2013-12-11  2:31                       ` Ethan Zhao
  -- strict thread matches above, loose matches on Subject: below --
2013-12-09 10:04 Ethan Zhao
2013-12-09 11:18 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131208140100.GA22793@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ethan.kernel@gmail.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raghavendra.kt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.