From: Theodore Ts'o <tytso@mit.edu>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: fix del_timer() misuse for ->s_err_report
Date: Sun, 8 Dec 2013 20:56:28 -0500 [thread overview]
Message-ID: <20131209015628.GA12883@thunk.org> (raw)
In-Reply-To: <20131204072926.GK10323@ZenIV.linux.org.uk>
On Wed, Dec 04, 2013 at 07:29:26AM +0000, Al Viro wrote:
> That thing should be del_timer_sync(); consider what happens
> if ext4_put_super() call of del_timer() happens to come just as it's
> getting run on another CPU. Since that timer reschedules itself
> to run next day, you are pretty much guaranteed that you'll end up
> with kfree'd scheduled timer, with usual fun consequences. AFAICS,
> that's -stable fodder all way back to 2010... [the second del_timer_sync()
> is almost certainly not needed, but it doesn't hurt either]
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Nice catch. Thanks, applied.
- Ted
prev parent reply other threads:[~2013-12-09 1:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 7:29 [PATCH] fix del_timer() misuse for ->s_err_report Al Viro
2013-12-09 1:56 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131209015628.GA12883@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.