All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Sebastian Reichel <sre@debian.org>
Cc: Sebastian Reichel <sre@ring0.de>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Dmitry Torokhov <dtor@mail.ru>,
	linux-input@vger.kernel.org,
	Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Rob Landley <rob@landley.net>,
	Grant Likely <grant.likely@linaro.org>,
	devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Documentation: dt: Document TSC2005 DT binding
Date: Mon, 9 Dec 2013 09:46:38 -0800	[thread overview]
Message-ID: <20131209174638.GC12527@atomide.com> (raw)
In-Reply-To: <1386284979-9680-3-git-send-email-sre@debian.org>

* Sebastian Reichel <sre@debian.org> [131205 15:11]:
> Add devicetree binding documentation for TSC2005 touchscreen.
> 
> Signed-off-by: Sebastian Reichel <sre@debian.org>
> ---
>  .../bindings/input/touchscreen/tsc2005.txt         | 49 ++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt b/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt
> new file mode 100644
> index 0000000..4e7df0b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt
> @@ -0,0 +1,49 @@
> +* TSC2005 Touchscreen
> +
> +Required properties:
> + - compatible		      : "ti,tsc2005"
> + - reg			      : SPI device address
> + - spi-max-frequency	      : Maximal SPI speed
> + - interrupts		      : IRQ specifier
> + - reset-gpio		      : GPIO specifier
> +
> +Optional properties:
> + - ti,fuzz-x		      : integer, X noise value of the touchscreen
> +				(defaults to 4)
> + - ti,fuzz-y		      : integer, Y noise value of the touchscreen
> +				(defaults to 8)
> + - ti,fuzz-pressure	      : integer, pressure noise value of the touchscreen
> +				(defaults to 2)
> + - ti,max-x		      : integer, maximum reported x value
> +				(defaults to 4096)
> + - ti,max-y		      : integer, maximum reported y value
> +				(defaults to 4096)
> + - ti,max-pressure	      : integer, maximum reported pressure
> +				(defaults to 4096)
> + - ti,x-plate-resistance      : integer, resistance of the touchscreen's X plates
> +				in ohm (defaults to 280)
> + - ti,esd-recovery-timeout-ms : integer, if the touchscreen does not respond after
> +				the configured time (in milli seconds), the driver
> +				will reset it. This is disabled by default.

Instead of adding these optional ti,* properties you can set them in the
driver directly in the of_match table based on the compatible flag. Then
you can pass compatible flag like ti,tsc2005-nokia-n900, or the name of
the LCD panel. Most likely these depend on the LCD panel selected.

Regards,

Tony


> +Example:
> +
> +&mcspi1 {
> +	tsc2005@0 {
> +		compatible = "ti,tsc2005";
> +		spi-max-frequency = <6000000>;
> +		reg = <0>;
> +		reset-gpio = <&gpio4 8 GPIO_ACTIVE_HIGH>; /* 104 */
> +		interrupt-parent = <&gpio4>;
> +		interrupts = <4 IRQ_TYPE_NONE>; /* gpio line 100 */
> +
> +		ti,fuzz-x = <4>;
> +		ti,fuzz-y = <7>;
> +		ti,fuzz-pressure = <2>;
> +		ti,max-x = <4096>;
> +		ti,max-y = <4096>;
> +		ti,max-pressure = <2048>;
> +		ti,x-plate-resistance = <280>;
> +		ti,esd-recovery-timeout-ms = <8000>;
> +	};
> +}
> -- 
> 1.8.4.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2013-12-09 17:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-05 23:09 [PATCH 0/2] tsc2005 DT binding Sebastian Reichel
2013-12-05 23:09 ` [PATCH 1/2] Input: tsc2005: add DT support Sebastian Reichel
2013-12-05 23:09 ` [PATCH 2/2] Documentation: dt: Document TSC2005 DT binding Sebastian Reichel
2013-12-09 17:46   ` Tony Lindgren [this message]
2013-12-09 18:24     ` Sebastian Reichel
2013-12-10  0:06       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131209174638.GC12527@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dtor@mail.ru \
    --cc=grant.likely@linaro.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=sre@debian.org \
    --cc=sre@ring0.de \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.