From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Frederic Sowa Subject: Re: [PATCH 1/1] ipv6 addrconf:fix preferred lifetime state-changing behavior while valid_lft is infinity Date: Tue, 10 Dec 2013 00:47:04 +0100 Message-ID: <20131209234704.GF7396@order.stressinduktion.org> References: <4AE7B88EC8BA74469869BB7EEB7D66671BF656D2@g01jpexmbyt23> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: "netdev@vger.kernel.org" To: "Asano, Yasushi" Return-path: Received: from order.stressinduktion.org ([87.106.68.36]:43566 "EHLO order.stressinduktion.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989Ab3LIXrF (ORCPT ); Mon, 9 Dec 2013 18:47:05 -0500 Content-Disposition: inline In-Reply-To: <4AE7B88EC8BA74469869BB7EEB7D66671BF656D2@g01jpexmbyt23> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Dec 09, 2013 at 05:54:37AM +0000, Asano, Yasushi wrote: > from: Yasushi Asano > > There is a problem when setting the lifetime of an IPv6 address. > When I set preferred_lft to a value not zero or infinity, while valid_lft is infinity(0xffffffff) > preferred lifetime is set to forever and does not update. > Therefore preferred lifetime never becomes deprecated. > > I think valid lifetime and preferred lifetime should be set independently, > even if valid lifetime is infinity, preferred lifetime must expire correctly (meaning it must eventually become deprecated) > > I made a patch for 3.12 stable to solve the problem. This indeed could be improved. Thanks for the patch. But you should base it on net-next so it can be applied and please clean up the warnings and errors if you run the patch through ./scripts/checkpatch --strict. Thank you, Hannes