From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>,
Grant Likely <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/3] pinctrl: Add msm8x74 configuration
Date: Tue, 10 Dec 2013 00:27:01 -0800 [thread overview]
Message-ID: <20131210082700.GE11990@sonymobile.com> (raw)
In-Reply-To: <52A63829.10509@codeaurora.org>
On Mon 09 Dec 13:37 PST 2013, Stephen Boyd wrote:
> On 12/09/13 00:18, Linus Walleij wrote:
> > On Fri, Dec 6, 2013 at 11:22 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> >> On 12/05/13 18:10, Bjorn Andersson wrote:
> > As the driver is merged I expect fixes to come in as additional patches.
> >
> >>> Add initial definition of parameters for pinctrl-msm for the msm8x74
> >>> platform.
> >> Hmm. We've tried to remove 'x' from our code because it isn't really
> >> accurate and leads to more confusion.
> > So does this pin controller have a real name in the data sheet?
>
> We call it TLMM (top-level mode mux). So far there have been three major
> revisions of the hardware and 8974 uses the latest version.
>
The pinctrl-msm.c driver would be the TLMM (v2 and v3) driver...
> >
> > I usually prefer to name the drivers after the name of the IP
> > block rather than the SoC if possible.
> >
> > Or should it just be named pinctrl-msm.c?
>
> Leaving the pinctrl-msm.c file as in these patches is fine. For the SoC
> specific data files we should use the base chip name which in this case
> is 8974. I suppose the goal of pinctrl-msm8x74.c is to support 8974 and
> 8074 SoCs in the same file because they're almost exactly the same minus
> some pins losing their "modem" functions. Given that, the file names are
> fine but the binding and the data structures should be specific about
> which SoC we're talking about.
...and the pinctrl-msm8x74.c would be the data for SoCs matching that name.
Currently we know that 8074 is a 8974 without modem and the document I have
describing this incarnation of the SoC describes 8274, 8674 and 8974.
So as Stephen suggest; we could keep the name pinctrl-msm8x74.c as is and
we change the compatible to be explicit about this is qcom,msm8974-pinctrl.
That would give us room to handle any differences between 8074 and 8974 within
this file.
What do you say? Should I prepare a patch for this?
Regards,
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: bjorn.andersson@sonymobile.com (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] pinctrl: Add msm8x74 configuration
Date: Tue, 10 Dec 2013 00:27:01 -0800 [thread overview]
Message-ID: <20131210082700.GE11990@sonymobile.com> (raw)
In-Reply-To: <52A63829.10509@codeaurora.org>
On Mon 09 Dec 13:37 PST 2013, Stephen Boyd wrote:
> On 12/09/13 00:18, Linus Walleij wrote:
> > On Fri, Dec 6, 2013 at 11:22 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> >> On 12/05/13 18:10, Bjorn Andersson wrote:
> > As the driver is merged I expect fixes to come in as additional patches.
> >
> >>> Add initial definition of parameters for pinctrl-msm for the msm8x74
> >>> platform.
> >> Hmm. We've tried to remove 'x' from our code because it isn't really
> >> accurate and leads to more confusion.
> > So does this pin controller have a real name in the data sheet?
>
> We call it TLMM (top-level mode mux). So far there have been three major
> revisions of the hardware and 8974 uses the latest version.
>
The pinctrl-msm.c driver would be the TLMM (v2 and v3) driver...
> >
> > I usually prefer to name the drivers after the name of the IP
> > block rather than the SoC if possible.
> >
> > Or should it just be named pinctrl-msm.c?
>
> Leaving the pinctrl-msm.c file as in these patches is fine. For the SoC
> specific data files we should use the base chip name which in this case
> is 8974. I suppose the goal of pinctrl-msm8x74.c is to support 8974 and
> 8074 SoCs in the same file because they're almost exactly the same minus
> some pins losing their "modem" functions. Given that, the file names are
> fine but the binding and the data structures should be specific about
> which SoC we're talking about.
...and the pinctrl-msm8x74.c would be the data for SoCs matching that name.
Currently we know that 8074 is a 8974 without modem and the document I have
describing this incarnation of the SoC describes 8274, 8674 and 8974.
So as Stephen suggest; we could keep the name pinctrl-msm8x74.c as is and
we change the compatible to be explicit about this is qcom,msm8974-pinctrl.
That would give us room to handle any differences between 8074 and 8974 within
this file.
What do you say? Should I prepare a patch for this?
Regards,
Bjorn
next prev parent reply other threads:[~2013-12-10 8:27 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 2:10 [PATCH v2 0/3] pinctrl: Qualcomm 8x74 pinctrl driver Bjorn Andersson
2013-12-06 2:10 ` Bjorn Andersson
2013-12-06 2:10 ` [PATCH v2 1/3] pinctrl: Add Qualcomm TLMM driver Bjorn Andersson
2013-12-06 2:10 ` Bjorn Andersson
2013-12-06 21:40 ` Stephen Boyd
2013-12-06 21:40 ` Stephen Boyd
2013-12-10 8:10 ` Bjorn Andersson
2013-12-10 8:10 ` Bjorn Andersson
2013-12-11 1:42 ` Stephen Boyd
2013-12-11 1:42 ` Stephen Boyd
2013-12-12 19:09 ` Linus Walleij
2013-12-12 19:09 ` Linus Walleij
2014-11-25 19:55 ` Timur Tabi
2014-11-25 19:55 ` Timur Tabi
2014-11-26 17:41 ` Bjorn Andersson
2014-11-26 17:41 ` Bjorn Andersson
2013-12-06 2:10 ` [PATCH v2 2/3] pinctrl: Add msm8x74 configuration Bjorn Andersson
2013-12-06 2:10 ` Bjorn Andersson
2013-12-06 22:22 ` Stephen Boyd
2013-12-06 22:22 ` Stephen Boyd
2013-12-09 8:18 ` Linus Walleij
2013-12-09 8:18 ` Linus Walleij
2013-12-09 21:37 ` Stephen Boyd
2013-12-09 21:37 ` Stephen Boyd
2013-12-10 8:27 ` Bjorn Andersson [this message]
2013-12-10 8:27 ` Bjorn Andersson
2013-12-10 8:41 ` Bjorn Andersson
2013-12-10 8:41 ` Bjorn Andersson
2013-12-11 1:49 ` Stephen Boyd
2013-12-11 1:49 ` Stephen Boyd
2013-12-12 19:15 ` Linus Walleij
2013-12-12 19:15 ` Linus Walleij
2013-12-12 21:16 ` Linus Walleij
2013-12-12 21:16 ` Linus Walleij
2013-12-13 4:24 ` Bjorn Andersson
2013-12-13 4:24 ` Bjorn Andersson
2013-12-12 21:22 ` Linus Walleij
2013-12-12 21:22 ` Linus Walleij
2013-12-06 2:10 ` [PATCH v2 3/3] pinctrl: Add documentation for pinctrl-msm8x74 Bjorn Andersson
2013-12-06 2:10 ` Bjorn Andersson
2013-12-06 13:56 ` [PATCH v2 0/3] pinctrl: Qualcomm 8x74 pinctrl driver Linus Walleij
2013-12-06 13:56 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210082700.GE11990@sonymobile.com \
--to=bjorn.andersson@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sboyd@codeaurora.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.