From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqP2P-0002v9-Lt for qemu-devel@nongnu.org; Tue, 10 Dec 2013 10:15:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqP2J-0003IU-Vj for qemu-devel@nongnu.org; Tue, 10 Dec 2013 10:15:53 -0500 Received: from hall.aurel32.net ([2001:bc8:30d7:101::1]:41413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqP2J-0003IO-Q9 for qemu-devel@nongnu.org; Tue, 10 Dec 2013 10:15:47 -0500 Date: Tue, 10 Dec 2013 11:28:17 +0100 From: Aurelien Jarno Message-ID: <20131210102817.GA17981@ohm.rr44.fr> References: <1379620717-20358-1-git-send-email-rth@twiddle.net> <20131208134810.GG4601@hall.aurel32.net> <52A618A2.6030905@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <52A618A2.6030905@twiddle.net> Subject: Re: [Qemu-devel] [PATCH] tcg: Use bitmaps for free temporaries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Mon, Dec 09, 2013 at 11:23:14AM -0800, Richard Henderson wrote: > On 12/08/2013 05:48 AM, Aurelien Jarno wrote: > > It looks fine to me, though I don't know if it has any impact on the > > performances. > > I couldn't measure any performance difference at all. Ok great. Still in the long term we should provide a dedicated find_first_bit function that can be inlined, so that the compiler can do numerous optimizations in the case the size is known at compile time. > But for me, the improvement in debugging for the translators is important. > Yeah, I understand the point, that's why I gave a reviewed-by: Aurelien -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net