Re: [LTP] [PATCH] fchownat/fchownat01.c: cleanup

[chrubis@suse.cz]

Hi!
> > > -uid_t uid;
> > > -gid_t gid;
> > > -
> > > -int myfchownat(int dirfd, const char *filename, uid_t owner, gid_t group,
> > > -	       int flags)
> > > -{
> > > -	return ltp_syscall(__NR_fchownat, dirfd, filename, owner, group, flags);
> > > -}
> > 
> > Hmm, glibc 2.4 (first one with fchownat() support) has been released in
> > 2006. I wonder if seven years is long enough and if we can get rid of
> > the wrapper now... Moreover I'm not sure what is the status of
> > alternative libc implementations.
> > 
> > There still may be enterprise distributions that still have older glibc
> > than that. Anybody out there?
> 
> To my knowledge the oldest RHEL LTP is run against is RHEL5.3,
> which has glibc 2.5.

It seems to be glibc 2.4 for SLES10 SP3, which is just barely enough.

So I would just keep the wrapper for a few more years. Or even better we
should create a configure check for the fchownat() syscall and define
the wrapper only when it's not available.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Sponsored by Intel(R) XDK 
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list