All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: dinguyen@altera.com
Cc: dinh.linux@gmail.com, daniel.lezcano@linaro.org,
	tglx@linutronix.de, jamie@jamieiles.com,
	linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
	heiko@sntech.de
Subject: Re: [PATCHv4] clocksource: dw_apb_timer_of: Fix read_sched_clock
Date: Tue, 10 Dec 2013 16:53:49 +0100	[thread overview]
Message-ID: <20131210155349.GC1995@gmail.com> (raw)
In-Reply-To: <1386690395-27182-1-git-send-email-dinguyen@altera.com>


* dinguyen@altera.com <dinguyen@altera.com> wrote:

> From: Dinh Nguyen <dinguyen@altera.com>
> 
> The read_sched_clock should return the ~value because the clock is a
> countdown implementation. read_sched_clock() should be the same as
> __apbt_read_clocksource().
> 
> Maintain backwards compatibility for "dw-apb-timer-sp" and
> "dw-apb-timer-osc".

Are these two independent fixes? If yes then they should be in 
separate patches. In general we want to apply minimized, obvious, 
single-purpose fix patches.

Thanks,

	Ingo

  reply	other threads:[~2013-12-10 15:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10 15:46 [PATCHv4] clocksource: dw_apb_timer_of: Fix read_sched_clock dinguyen
2013-12-10 15:53 ` Ingo Molnar [this message]
2013-12-10 15:53   ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131210155349.GC1995@gmail.com \
    --to=mingo@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=dinguyen@altera.com \
    --cc=dinh.linux@gmail.com \
    --cc=heiko@sntech.de \
    --cc=jamie@jamieiles.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.